Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xSQLServer: Opt-in for script files common tests #707

Closed
johlju opened this issue Jul 22, 2017 · 0 comments · Fixed by #708
Closed

xSQLServer: Opt-in for script files common tests #707

johlju opened this issue Jul 22, 2017 · 0 comments · Fixed by #708
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Jul 22, 2017

Details of the scenario you tried and the problem that is occurring:
We should opt-in for the script files common tests so that we can easier enforce the style guideline.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone. labels Jul 22, 2017
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jul 22, 2017
@johlju
Changes to xSQLServer
b56fa38 
Opt-in for script files common tests (issue dsccommunity#707).
  - Removed Byte Order Mark (BOM) from the files; DSCClusterSqlBuild.ps1,
    DSCFCISqlBuild.ps1, DSCSqlBuild.ps1, DSCSQLBuildEncrypted.ps1,
    SQLPush_SingleServer.ps1, 1-AddAvailabilityGroupListenerWithSameNameAsVCO.ps1,
    2-AddAvailabilityGroupListenerWithDifferentNameAsVCO.ps1,
    3-RemoveAvailabilityGroupListenerWithSameNameAsVCO.ps1,
    4-RemoveAvailabilityGroupListenerWithDifferentNameAsVCO.ps1,
    5-AddAvailabilityGroupListenerUsingDHCPWithDefaultServerSubnet.ps1,
    6-AddAvailabilityGroupListenerUsingDHCPWithSpecificSubnet.ps1,
    2-ConfigureInstanceToEnablePriorityBoost.ps1, 1-CreateEndpointWithDefaultValues.ps1,
    2-CreateEndpointWithSpecificPortAndIPAddress.ps1, 3-RemoveEndpoint.ps1,
    1-AddConnectPermission.ps1, 2-RemoveConnectPermission.ps1,
    3-AddConnectPermissionToAlwaysOnPrimaryAndSecondaryReplicaEachWithDifferentSqlServiceAccounts.ps1,
    4-RemoveConnectPermissionToAlwaysOnPrimaryAndSecondaryReplicaEachWithDifferentSqlServiceAccounts.ps1,
    1-MakeSureEndpointIsStarted.ps1, 2-MakeSureEndpointIsStopped.ps1,
    1-EnableTcpIpWithStaticPort.ps1, 2-EnableTcpIpWithDynamicPort.ps1,
    1-AddServerPermissionForLogin.ps1, 2-RemoveServerPermissionForLogin.ps1,
    1-ConfigureInstanceAsDistributor.ps1, 2-ConfigureInstanceAsPublisher.ps1,
    1-WaitForASingleClusterGroup.ps1, 2-WaitForMultipleClusterGroups.ps1.
@johlju johlju mentioned this issue Jul 22, 2017
Merged
5 tasks
johlju added a commit that referenced this issue Jul 24, 2017
@johlju
xSQLServer: Opt-in for script files common tests (#708)
7db2ffc 
- Opt-in for script files common tests (issue #707).
  - Removed Byte Order Mark (BOM) from the files; DSCClusterSqlBuild.ps1,
    DSCFCISqlBuild.ps1, DSCSqlBuild.ps1, DSCSQLBuildEncrypted.ps1,
    SQLPush_SingleServer.ps1, 1-AddAvailabilityGroupListenerWithSameNameAsVCO.ps1,
    2-AddAvailabilityGroupListenerWithDifferentNameAsVCO.ps1,
    3-RemoveAvailabilityGroupListenerWithSameNameAsVCO.ps1,
    4-RemoveAvailabilityGroupListenerWithDifferentNameAsVCO.ps1,
    5-AddAvailabilityGroupListenerUsingDHCPWithDefaultServerSubnet.ps1,
    6-AddAvailabilityGroupListenerUsingDHCPWithSpecificSubnet.ps1,
    2-ConfigureInstanceToEnablePriorityBoost.ps1, 1-CreateEndpointWithDefaultValues.ps1,
    2-CreateEndpointWithSpecificPortAndIPAddress.ps1, 3-RemoveEndpoint.ps1,
    1-AddConnectPermission.ps1, 2-RemoveConnectPermission.ps1,
    3-AddConnectPermissionToAlwaysOnPrimaryAndSecondaryReplicaEachWithDifferentSqlServiceAccounts.ps1,
    4-RemoveConnectPermissionToAlwaysOnPrimaryAndSecondaryReplicaEachWithDifferentSqlServiceAccounts.ps1,
    1-MakeSureEndpointIsStarted.ps1, 2-MakeSureEndpointIsStopped.ps1,
    1-EnableTcpIpWithStaticPort.ps1, 2-EnableTcpIpWithDynamicPort.ps1,
    1-AddServerPermissionForLogin.ps1, 2-RemoveServerPermissionForLogin.ps1,
    1-ConfigureInstanceAsDistributor.ps1, 2-ConfigureInstanceAsPublisher.ps1,
    1-WaitForASingleClusterGroup.ps1, 2-WaitForMultipleClusterGroups.ps1.
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xSQLServer: Opt-in for script files common tests johlju/SqlServerDsc
1 participant
@johlju