Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlRS: Rename parameters RSSQLServer and RSSQLInstanceName #923

Closed
johlju opened this issue Dec 1, 2017 · 4 comments · Fixed by #932
Closed

SqlRS: Rename parameters RSSQLServer and RSSQLInstanceName #923

johlju opened this issue Dec 1, 2017 · 4 comments · Fixed by #932
Assignees
@johlju
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Dec 1, 2017

Details of the scenario you tried and the problem that is occurring:
The work renaming parameters in issue #308 does not mention the parameters
RSSQLServer and RSSQLInstanceName in the resource SqlRS.

https://github.com/PowerShell/SqlServerDsc/blob/9a1080c4da5d513eb4191388206cf37c16c0a0fd/DSCResources/MSFT_SqlRS/MSFT_SqlRS.schema.mof#L5-L6

I suggest we rename them to DatabaseServerName and DatabaseInstanceName respectively.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added the discussion The issue is a discussion. label Dec 1, 2017
@johlju
Copy link
Member Author

johlju commented Dec 1, 2017

@nabrond @randomnote1 another one, what do you think?

@johlju johlju changed the title SqlRS: Rename parameters RSSQLServerand RSSQLInstanceName SqlRS: Rename parameters RSSQLServer and RSSQLInstanceName Dec 1, 2017
@randomnote1
Copy link
Contributor

Yes, I agree these should be updated for consistency.

@johlju johlju added breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. high priority The issue or PR should be resolved first. It is of less priority than the label 'Blocking Release'. and removed discussion The issue is a discussion. labels Dec 1, 2017
@nabrond
Copy link
Contributor

nabrond commented Dec 2, 2017

Concur.

@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Dec 5, 2017
@johlju
Copy link
Member Author

johlju commented Dec 5, 2017

Working on this.

johlju added a commit to johlju/SqlServerDsc that referenced this issue Dec 5, 2017
@johlju
Changes to SqlRS
c4ceab6 
- BREAKING CHANGE: Parameters RSSQLServer and RSSQLInstanceName has been renamed
  to DatabaseServerName and DatabaseInstanceName respectively (issue dsccommunity#923).
@johlju johlju mentioned this issue Dec 5, 2017
Merged
5 tasks
johlju added a commit that referenced this issue Dec 6, 2017
@johlju
BREAKING CHANGE: Rename parameters for SqlRS and SqlAGReplica (#932)
ae6c520 
- Changes to SqlRS
  - BREAKING CHANGE: Parameters RSSQLServer and RSSQLInstanceName has been renamed
    to DatabaseServerName and DatabaseInstanceName respectively (issue #923).
- Changes to SqlAGReplica
  - BREAKING CHANGE: Parameters PrimaryReplicaSQLServer and PrimaryReplicaSQLInstanceName
    has been renamed to PrimaryReplicaServerName and PrimaryReplicaInstanceName
    respectively (issue #922).
@vors vors removed the high priority The issue or PR should be resolved first. It is of less priority than the label 'Blocking Release'. label Dec 6, 2017
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Dec 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johlju johlju

Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BREAKING CHANGE: Rename parameters for SqlRS and SqlAGReplica johlju/SqlServerDsc
4 participants
@vors @nabrond @johlju @randomnote1