Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlServerDsc: Fix style of examples #1005

Merged
merged 2 commits into from
Jan 9, 2018
Merged

SqlServerDsc: Fix style of examples #1005

merged 2 commits into from
Jan 9, 2018

Conversation

johlju
Copy link
Member

@johlju johlju commented Jan 7, 2018 •
edited by joeyaiello
Loading

Pull Request (PR) description

This Pull Request (PR) fixes the following issues:
Fixes #1003

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

@johlju
Changes to SqlServerDsc
02b131d 
- Style changes in all examples, removing type [System.Management.Automation.Credential()]
  from credential parameters (issue dsccommunity#1003), and renamed the credential parameter so it is
  not using abbreviation.
@johlju johlju added the needs review The pull request needs a code review. label Jan 7, 2018
@codecov-io
Copy link

codecov-io commented Jan 7, 2018 •
edited
Loading

Codecov Report

Merging #1005 into dev will increase coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            dev   #1005    +/-   ##
=====================================
+ Coverage    97%     97%   +<1%     
=====================================
  Files        32      32            
  Lines      3904    3914    +10     
=====================================
+ Hits       3817    3827    +10     
  Misses       87      87

@johlju
Copy link
Member Author

johlju commented Jan 8, 2018

Reviewed 65 of 65 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Examples/Resources/SqlAG/2-RemoveAvailabilityGroup.ps1, line 35 at r1 (raw file):

[PSCredential]

Should be [System.Management.Automation.PSCredential]. Throughout.

Comments from Reviewable

@johlju
Copy link
Member Author

johlju commented Jan 8, 2018

Review status: 47 of 70 files reviewed at latest revision, 1 unresolved discussion.

Examples/Resources/SqlAG/2-RemoveAvailabilityGroup.ps1, line 35 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

[PSCredential]

Should be [System.Management.Automation.PSCredential]. Throughout.

Done.

Comments from Reviewable

@johlju
Copy link
Member Author

johlju commented Jan 9, 2018

:lgtm:

Reviewed 23 of 23 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@johlju johlju merged commit e8eaf91 into dsccommunity:dev Jan 9, 2018
@johlju johlju removed the needs review The pull request needs a code review. label Jan 20, 2018
@johlju johlju deleted the fix-style-examples branch March 12, 2018 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SqlServerDsc: Remove type [System.Management.Automation.Credential()] from examples
2 participants
@johlju @codecov-io