Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlWindowsFirewall: Unit test uses the latest unit test template #1091

Merged
merged 1 commit into from
Mar 17, 2018
Merged

SqlWindowsFirewall: Unit test uses the latest unit test template #1091

merged 1 commit into from
Mar 17, 2018

Conversation

TraGicCode
Copy link
Contributor

@TraGicCode TraGicCode commented Mar 16, 2018

Pull Request (PR) description

This updates the SqlWindowsFirewall DSC Resources unit test to use the newest template.

This Pull Request (PR) fixes the following issues

Fixes #1089

Task list

  • Added an entry under the Unreleased section in the CHANGELOG.md? Entry
    should say what was changed, and how that affects users (if applicable).

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Mar 16, 2018

Codecov Report

Merging #1091 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #1091   +/-   ##
====================================
  Coverage    97%     97%           
====================================
  Files        32      32           
  Lines      3930    3930           
====================================
  Hits       3844    3844           
  Misses       86      86

@johlju johlju added the needs review The pull request needs a code review. label Mar 17, 2018
@johlju
Copy link
Member

johlju commented Mar 17, 2018

:lgtm:


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju johlju changed the title SqlWindowsFirewall: Updated SqlWindowsFirewall resource to use latest unit test template. SqlWindowsFirewall: Unit test uses the latest unit test template Mar 17, 2018
@johlju johlju merged commit 51c0599 into dsccommunity:dev Mar 17, 2018
@johlju johlju removed the needs review The pull request needs a code review. label Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlWindowsFirewall: Update unit tests to use the same (newest) unit test template
3 participants