Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlAlwaysOnService: Resolve failing integration test #1169

Merged
merged 2 commits into from
Jun 30, 2018

Conversation

johlju
Copy link
Member

@johlju johlju commented Jun 30, 2018

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Fixes #1155

Task list

  • Added an entry under the Unreleased section in the CHANGELOG.md? Entry
    should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md?
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help?
  • Comment-based help added/updated?
  • Localization strings added/updated in all localization files as appropriate?
  • Examples appropriately added/updated?
  • Unit tests added/updated?
    See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible)?
    See DSC Resource Testing Guidelines.
  • New/changed code adheres to
    DSC Resource Style Guidelines
    and Best Practices?

This change is Reviewable

- Integration tests was updated to handle new IPv6 addresses on the AppVeyor
  build worker [issue dsccommunity#1155](dsccommunity#1155))
@johlju johlju added the needs review The pull request needs a code review. label Jun 30, 2018
@codecov-io
Copy link

codecov-io commented Jun 30, 2018

Codecov Report

Merging #1169 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #1169   +/-   ##
====================================
  Coverage    97%     97%           
====================================
  Files        33      33           
  Lines      4005    4005           
====================================
  Hits       3916    3916           
  Misses       89      89

@johlju
Copy link
Member Author

johlju commented Jun 30, 2018

:LGTM:

Merging this as soon as the tests passes since this resolved a blocking release issue (and blocks any other PR's from merging).


Reviewed 2 of 2 files at r1.
Review status: :shipit: complete! all files reviewed, all discussions resolved


Comments from Reviewable

@johlju johlju merged commit 9b6f768 into dsccommunity:dev Jun 30, 2018
@johlju johlju removed the needs review The pull request needs a code review. label Jun 30, 2018
@johlju johlju deleted the debug-issue-#1155 branch September 21, 2018 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlAlwaysOnService: BLOCKING RELEASE: Integration tests have started failing (on updated build worker image?)
2 participants