SqlServerNetwork: Refactored to not load assembly from GAC

[johlju]

Pull Request (PR) description

• Changes to SqlServerDsc
  • Updated helper function Restart-SqlService to have to new optional parameters
    SkipClusterCheck and SkipWaitForOnline. This was to support more aspects
    of the resource SqlServerNetwork.
• Changes to SqlServerNetwork
  • Refactor SqlServerNetwork to not load assembly from GAC (issue Error on AvailabilityGroup Creation: SqlAG #1151).
  • The resource now supports restarting the SQL Server service when both
    enabling and disabling the protocol.
  • Added integration tests for this resource
    (issue SqlServerNetwork: Integration test is missing for this resource #751).

This Pull Request (PR) fixes the following issues

Helps with issue #1151
Fixes #1051 (closing this since the issue is around code that has been removed).
Fixes #751
Fixes #581 (closing this since the issue is around code that has been removed).

Task list

• Added an entry under the Unreleased section in the CHANGELOG.md? Entry
  should say what was changed, and how that affects users (if applicable).
• Resource documentation added/updated in README.md?
• Resource parameter descriptions added/updated in README.md, schema.mof
  and comment-based help?
• Comment-based help added/updated?
• Localization strings added/updated in all localization files as appropriate?
• Examples appropriately added/updated?
• Unit tests added/updated?
  See DSC Resource Testing Guidelines.
• Integration tests added/updated (where possible)?
  See DSC Resource Testing Guidelines.
• New/changed code adheres to
  DSC Resource Style Guidelines
  and Best Practices?

---

This change is 

[codecov-io]

Codecov Report

Merging #1172 into dev will increase coverage by <1%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##            dev   #1172    +/-   ##
=====================================
+ Coverage    97%     97%   +<1%     
=====================================
  Files        33      33            
  Lines      4005    3994    -11     
=====================================
- Hits       3916    3907     -9     
+ Misses       89      87     -2

[johlju]

Reviewed 9 of 9 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions

---

CHANGELOG.md, line 7 at r1 (raw file):

aspectes

Typo

---

DSCResources/MSFT_SqlServerNetwork/MSFT_SqlServerNetwork.psm1, line 28 at r1 (raw file):

        [ValidateNotNullOrEmpty()]
        [System.String]
        $ServerName = $env:COMPUTERNAME,

This parameter can be removed.

---

DSCResources/MSFT_SqlServerNetwork/MSFT_SqlServerNetwork.psm1, line 225 at r1 (raw file):

SkipClusterCheck = $true

This should only be used if the previous state was disabled ($getTargetResourceResult.IsEnabled -eq $false), otherwise we never restart the cluster instance.

There is no way in the current implementation to restart a instance where the protocol was enabled from previously been disabled. An issue should be started to track this.

[johlju]

Reviewed 3 of 3 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

---

CHANGELOG.md, line 7 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

aspectes

Typo

Done

---

DSCResources/MSFT_SqlServerNetwork/MSFT_SqlServerNetwork.psm1, line 28 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This parameter can be removed.

Done

---

DSCResources/MSFT_SqlServerNetwork/MSFT_SqlServerNetwork.psm1, line 225 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

SkipClusterCheck = $true

This should only be used if the previous state was disabled ($getTargetResourceResult.IsEnabled -eq $false), otherwise we never restart the cluster instance.

There is no way in the current implementation to restart a instance where the protocol was enabled from previously been disabled. An issue should be started to track this.

Done. Opened issue #1174

[johlju]

Mergeíng this when tests passes.

Reviewable status: complete! all files reviewed, all discussions resolved