SqlServerDsc: Clean up integration tests using latest template

[johlju]

Pull Request (PR) description

• Changes to SqlServerDsc
  • Update integration tests to use the new integration test template.
• Changes to SqlServiceAccount
  • Now the correct service type string value is returned by the function
    Get-TargetResource. Previously one value was passed in as a parameter
    (e.g. DatabaseEngine), but a different string value as returned
    (e.g. SqlServer). Now Get-TargetResource return the same values
    that can be passed as values in the parameter ServiceType (issue SqlServiceAccount: Expected Get-TargetResource to return 'DatabaseEngine' and 'SqlServerAgent' #981).

This Pull Request (PR) fixes the following issues

• Fixes SqlServiceAccount: Expected Get-TargetResource to return 'DatabaseEngine' and 'SqlServerAgent' #981

Task list

• Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
  Entry should say what was changed, and how that affects users (if applicable).
• Resource documentation added/updated in README.md.
• Resource parameter descriptions added/updated in README.md, schema.mof
  and comment-based help.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Resource Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
• New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

---

This change is 

[johlju]

After this PR I can finally continue with new integration test for the other resource, now when there is finally space (time wise) for running more integration tests.

[codecov-io]

Codecov Report

Merging #1278 into dev will increase coverage by <1%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##            dev   #1278    +/-   ##
=====================================
+ Coverage    97%     97%   +<1%     
=====================================
  Files        35      35            
  Lines      4311    4323    +12     
=====================================
+ Hits       4208    4220    +12     
  Misses      103     103

[johlju]

Reviewed 65 of 65 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions

---

Tests/Integration/MSFT_SqlServerNetwork.config.ps1, line 39 at r1 (raw file):

}

Configuration MSFT_SqlServerNetwork_SetDisabled_Config

We should have comment-based help here.

---

Tests/Integration/MSFT_SqlServerSecureConnection.config.ps1, line 34 at r1 (raw file):

}

Configuration MSFT_SqlServerSecureConnection_AddSecureConnection_Config

We should have comment-based help here.

---

Tests/Integration/MSFT_SqlSetup.config.ps1, line 124 at r1 (raw file):

        (ConvertTo-SecureString -String $ConfigurationData.AllNodes.SqlAgentServiceSecondaryAccountPassword -AsPlainText -Force))

Configuration MSFT_SqlSetup_CreateDependencies_Config

We should have comment-based help here.

[johlju]

Reviewable status: 62 of 65 files reviewed, 1 unresolved discussion (waiting on @johlju)

---

Tests/Integration/MSFT_SqlServerNetwork.config.ps1, line 39 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

We should have comment-based help here.

Done

---

Tests/Integration/MSFT_SqlServerSecureConnection.config.ps1, line 34 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

We should have comment-based help here.

Done

---

Tests/Integration/MSFT_SqlSetup.config.ps1, line 124 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

We should have comment-based help here.

Done

[johlju]

Reviewed 3 of 3 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

[johlju]

Reviewable status: complete! all files reviewed, all discussions resolved