SqlServerMemory: Localization, unit tests and fix bug #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1330 +/- ##
=====================================
+ Coverage 98% 98% +<1%
=====================================
Files 36 36
Lines 4889 4906 +17
=====================================
+ Hits 4817 4835 +18
+ Misses 72 71 -1 |
- Added en-US localization (issue dsccommunity#617). - No longer will the resource set the MinMemory value if it was provided in a configuration that also set the `Ensure` parameter to 'Absent' (issue dsccommunity#1329). - Refactored unit tests to simplify them add add slightly more code coverage.
johlju
commented
Apr 25, 2019
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion
DSCResources/MSFT_SqlServerMemory/en-US/MSFT_SqlServerMemory.strings.psd1, line 11 at r1 (raw file):
{0}\{1}
This should be escaped \\
johlju
commented
Apr 25, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
DSCResources/MSFT_SqlServerMemory/en-US/MSFT_SqlServerMemory.strings.psd1, line 11 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
{0}\{1}This should be escaped
\\
Done
johlju
commented
Apr 25, 2019
There was a problem hiding this comment.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
in a configuration that also set the
Ensureparameter to 'Absent' (issue SqlMemory: Sets MinMemory even if state should be absent #1329).coverage.
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is