Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-pipelines.yml: issue #1466 #1467

Closed
wants to merge 8 commits into from
Closed

Conversation

dwilkie1
Copy link

@dwilkie1 dwilkie1 commented Jan 29, 2020

Pull Request (PR) description

  • Changed hosted agent to newer YAML VM Image Label

This Pull Request (PR) fixes the following issues

-Fix #1466

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju
Copy link
Member

johlju commented Jan 30, 2020

Seems there a low disk space on C:\on that image. Integration tests fail with

Exit message:                  Insufficient space available in directory C:\Program Files\Microsoft SQL 
2020-01-29T22:45:29.1096477Z Server\.  0MB is required for this feature, and 699MB is required for all features on this volume.  451MB is available.

Is there another disk available on the image you think? Or maybe we need to change the build image?

@johlju johlju added the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Jan 30, 2020
@dwilkie1
Copy link
Author

dwilkie1 commented Jan 30, 2020

Seems there a low disk space on C:\on that image. Integration tests fail with

Exit message:                  Insufficient space available in directory C:\Program Files\Microsoft SQL 
2020-01-29T22:45:29.1096477Z Server\.  0MB is required for this feature, and 699MB is required for all features on this volume.  451MB is available.

Is there another disk available on the image you think? Or maybe we need to change the build image?

Per this link we get the following options: "windows-latest", "windows-2019" or "vs2017-win2016".
I went and got the disk info on all three:
image
image
image

For comparison, here's the current image:
image

So there should be enough space. It's more than the win1803 image.

@johlju
Copy link
Member

johlju commented Jan 30, 2020

Hmm. strange. According to that it should be enough disk space. 🤔 Let me kick off the tests again, see if it was temporary. 🤔

@dwilkie1
Copy link
Author

@johlju looks like the same issue.

@johlju
Copy link
Member

johlju commented Jan 30, 2020

That seems very strange. Can we check how the diskspace is changing for each install in the integration test for SqlSetup? 🤔
We could change install drive for the setup that is failing.

@dwilkie1
Copy link
Author

dwilkie1 commented Feb 5, 2020

I'm struggling with how to insert that into the integration test script. Can you give me a hint?

@johlju
Copy link
Member

johlju commented Feb 6, 2020

Absolutely. But need to work on a other stuff and must be away this weekend, but will look into this to help you as soon as I can. I have this on the todo-list. 🙂

@stale
Copy link

stale bot commented Feb 20, 2020

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

@stale stale bot added the abandoned The pull request has been abandoned. label Feb 20, 2020
@johlju
Copy link
Member

johlju commented Mar 22, 2020

@dwilkie1 Sorry I haven't been able to get to it until now. I tried to push a new branch with these changes, and it seemed to just work. I wonder if there was issues with Azure Devops when you tried last time. 🤔

I am making other changes as well to the pipeline so I will send in a new PR that will close this one. We will see if I get the same problems when sending in a PR.

Thank you for your work on this!

@dwilkie1
Copy link
Author

dwilkie1 commented Mar 22, 2020 via email

@johlju
Copy link
Member

johlju commented Mar 22, 2020

I'm glad the resources are coming to use! Please continue contributing to the resources. 😄

@johlju johlju closed this in #1480 Mar 23, 2020
@johlju johlju removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. abandoned The pull request has been abandoned. labels Mar 23, 2020
@johlju
Copy link
Member

johlju commented Mar 23, 2020

@dwilkie1 This was now fixed in PR #1480. Thank you again for your work on this! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure DevOps is removing older build images
3 participants