Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlSetup: Added the properties NpEnabled and TcpEnabled #1521

Merged

Conversation

johlju
Copy link
Member

@johlju johlju commented May 3, 2020

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label May 3, 2020
@johlju johlju force-pushed the f/add-property-NPENABLED-and-TCPENABLED branch from e286dda to 87e4d5c Compare May 3, 2020 14:18
@codecov
Copy link

codecov bot commented May 3, 2020

Codecov Report

Merging #1521 into master will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1521   +/-   ##
======================================
  Coverage      98%     98%           
======================================
  Files          39      39           
  Lines        5921    5927    +6     
======================================
+ Hits         5826    5832    +6     
  Misses         95      95           

@johlju johlju force-pushed the f/add-property-NPENABLED-and-TCPENABLED branch 2 times, most recently from d55ace1 to c5adb4a Compare May 5, 2020 13:51
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions


source/DSCResources/DSC_SqlSetup/DSC_SqlSetup.psm1, line 1274 at r1 (raw file):

 $setupArguments['NPENABLED'] = 0

This is not testes in the unit test


source/DSCResources/DSC_SqlSetup/DSC_SqlSetup.psm1, line 1286 at r1 (raw file):

$setupArguments['TCPENABLED'] = 0

This is not testes in the unit test

@johlju johlju added waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. and removed needs review The pull request needs a code review. labels May 5, 2020
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 6 of 8 files reviewed, all discussions resolved (waiting on @johlju)


source/DSCResources/DSC_SqlSetup/DSC_SqlSetup.psm1, line 1274 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…
 $setupArguments['NPENABLED'] = 0

This is not testes in the unit test

Done


source/DSCResources/DSC_SqlSetup/DSC_SqlSetup.psm1, line 1286 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…
$setupArguments['TCPENABLED'] = 0

This is not testes in the unit test

Done

@johlju johlju added needs review The pull request needs a code review. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels May 6, 2020
@johlju johlju force-pushed the f/add-property-NPENABLED-and-TCPENABLED branch from bfe582e to 0559270 Compare May 6, 2020 08:51
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit 356c11a into dsccommunity:master May 6, 2020
@johlju johlju deleted the f/add-property-NPENABLED-and-TCPENABLED branch May 6, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review The pull request needs a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlSetup: Missing Configuration Feature/Options : Network Configurations
1 participant