-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlSetup: Added the properties NpEnabled and TcpEnabled #1521
SqlSetup: Added the properties NpEnabled and TcpEnabled #1521
Conversation
e286dda
to
87e4d5c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1521 +/- ##
======================================
Coverage 98% 98%
======================================
Files 39 39
Lines 5921 5927 +6
======================================
+ Hits 5826 5832 +6
Misses 95 95 |
d55ace1
to
c5adb4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 8 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions
source/DSCResources/DSC_SqlSetup/DSC_SqlSetup.psm1, line 1274 at r1 (raw file):
$setupArguments['NPENABLED'] = 0
This is not testes in the unit test
source/DSCResources/DSC_SqlSetup/DSC_SqlSetup.psm1, line 1286 at r1 (raw file):
$setupArguments['TCPENABLED'] = 0
This is not testes in the unit test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 6 of 8 files reviewed, all discussions resolved (waiting on @johlju)
source/DSCResources/DSC_SqlSetup/DSC_SqlSetup.psm1, line 1274 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
$setupArguments['NPENABLED'] = 0
This is not testes in the unit test
Done
source/DSCResources/DSC_SqlSetup/DSC_SqlSetup.psm1, line 1286 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
$setupArguments['TCPENABLED'] = 0
This is not testes in the unit test
Done
bfe582e
to
0559270
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
Pull Request (PR) description
NpEnabled
andTcpEnabled
(issue SqlSetup: Missing Configuration Feature/Options : Network Configurations #1161).This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
and comment-based help.
This change is