Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: Updated comment-based help (issue #1500) #1587

Merged
merged 3 commits into from
Jul 9, 2020

Conversation

johlju
Copy link
Member

@johlju johlju commented Jul 7, 2020

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Jul 7, 2020
@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #1587 into master will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1587   +/-   ##
======================================
  Coverage      98%     98%           
======================================
  Files          37      37           
  Lines        6074    6082    +8     
======================================
+ Hits         5970    5978    +8     
  Misses        104     104           

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 22 of 22 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit 359104f into dsccommunity:master Jul 9, 2020
@johlju johlju deleted the fix/comment-based-help branch July 9, 2020 07:02
@johlju johlju removed the needs review The pull request needs a code review. label Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlServerDsc: Fix comment-based help formatting throughout
1 participant