SqlReplication: Remove duplicate function

[johlju]

Pull Request (PR) description

• SqlServerDsc
  • Updated code formatting using latest release of PSScriptAnalyzer.
  • The URLs in the CHANGELOG.md that was pointing to issues is now
    referencing the new repository name and URL.
• SqlServerDsc.Common
  • The helper function Get-SqlInstanceMajorVersion no longer have a default
    value for parameter InstanceName since the parameter is mandatory
    and it was never used.
• SqlReplication
  • The resource are now using the helper function Get-SqlInstanceMajorVersion
    (issue SqlReplication: Replace Get-SqlServerMajorVersion #1408).

This Pull Request (PR) fixes the following issues

• Fixes SqlReplication: Replace Get-SqlServerMajorVersion #1408

Task list

• Added an entry to the change log under the Unreleased section of the
  file CHANGELOG.md. Entry should say what was changed and how that
  affects users (if applicable), and reference the issue being resolved
  (if applicable).
• Resource documentation updated in the resource's README.md.
• Resource parameter descriptions updated in schema.mof.
• Comment-based help updated, including parameter descriptions.
• Localization strings updated.
• Examples updated.
• Unit tests updated. See DSC Community Testing Guidelines.
• Integration tests updated (where possible). See DSC Community Testing Guidelines.
• Code changes adheres to DSC Community Style Guidelines.

---

This change is 

[codecov]

Codecov Report

Merging #1612 into master will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1612   +/-   ##
======================================
- Coverage      98%     98%   -1%     
======================================
  Files          37      37           
  Lines        5988    5981    -7     
======================================
- Hits         5899    5892    -7     
  Misses         89      89           

Flag	Coverage Δ
#unit	98% <100%> (-1%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...sources/DSC_SqlReplication/DSC_SqlReplication.psm1	62% <100%> (-3%)	⬇️
...dules/SqlServerDsc.Common/SqlServerDsc.Common.psm1	97% <100%> (ø)

[johlju]

Reviewed 4 of 4 files at r1, 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved