SqlMaxDop Fix for #396

[Fiander]

Pull Request (PR) description

Added three return values for Get-TargetResource and tests

This Pull Request (PR) fixes the following issues

• Fixes SqlServerMaxDop: Should return values for Ensure and DynamicAlloc when Get-DscConfiguration is called #396

Task list

• [X ] Added an entry to the change log under the Unreleased section of the
  file CHANGELOG.md. Entry should say what was changed and how that
  affects users (if applicable), and reference the issue being resolved
  (if applicable).
• Resource documentation updated in the resource's README.md.
• Resource parameter descriptions updated in schema.mof.
• Comment-based help updated, including parameter descriptions.
• Localization strings updated.
• Examples updated.
• Unit tests updated. See DSC Community Testing Guidelines.
• Integration tests updated (where possible). See DSC Community Testing Guidelines.
• Code changes adheres to DSC Community Style Guidelines.

---

This change is 

[codecov]

Codecov Report

Merging #1644 (f46ecf8) into master (f5724c7) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1644   +/-   ##
======================================
  Coverage      98%     98%           
======================================
  Files          38      38           
  Lines        6177    6179    +2     
======================================
+ Hits         6085    6087    +2     
  Misses         92      92           

Flag	Coverage Δ
unit	98% <100%> (+<1%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...urce/DSCResources/DSC_SqlMaxDop/DSC_SqlMaxDop.psm1	100% <100%> (ø)

[johlju]

This looks good, just a tiny change in the CHANGELOG.md.

Reviewed 3 of 3 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Fiander)

---

CHANGELOG.md, line 7 at r2 (raw file):

## [Unreleased]

Before the entry we need to add header ### Fixed or ### Changed depending on what suits best (see https://keepachangelog.com/en/1.0.0/). Also a blank rows around the header. See previous log entries.

---

source/DSCResources/DSC_SqlMaxDop/DSC_SqlMaxDop.psm1, line 55 at r2 (raw file):

Ensure

Non-blocking, just thoughts. This resource shouldn't have had a Ensure parameter in the first place, since it does not create an object. Realized now that it have an Ensure property. Technical debt... . 🙂

[Fiander]

Personally i like this ensure. It sets the maxdop to the server default when set to Absent.
No need to figure out what the setting should be when you dont want to set maxdop anymore.

removing it would als make it a breaking change

[johlju]

Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Fiander)