Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xSQLServerDatabaseDefaultLocations: New Resource #854

Closed

Conversation

PaulFeaser
Copy link
Contributor

@PaulFeaser PaulFeaser commented Oct 4, 2017

Pull Request (PR) description
Created new resource for setting Database Default Locations (Data/Log/Backup) for SQL Server

This Pull Request (PR) fixes the following issues:
Fixes #656

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

@msftclas
Copy link

msftclas commented Oct 4, 2017

CLA assistant check
All CLA requirements met.

@PaulFeaser
Copy link
Contributor Author

@msftclas I'm full-time Microsoft employee, not sure why it is asking for a signed CLA.

@codecov-io
Copy link

codecov-io commented Oct 4, 2017

Codecov Report

Merging #854 into dev will increase coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #854    +/-   ##
====================================
+ Coverage    96%    96%   +<1%     
====================================
  Files        31     32     +1     
  Lines      3407   3453    +46     
====================================
+ Hits       3290   3336    +46     
  Misses      117    117

@johlju
Copy link
Member

johlju commented Oct 4, 2017

@PaulFeaser Contact @mbreakey3 or @kwirkykat and make sure you are in the Microsoft organisation in GitHub (think that's the problem).

@johlju
Copy link
Member

johlju commented Oct 4, 2017

@PaulFeaser Could you please rename the resource to 'xSQLServerDatabaseDefaultLocation' (singular). Throughout the files.

@johlju johlju added the waiting for author response The pull request is waiting for the author to respond to comments in the pull request. label Oct 4, 2017
@PaulFeaser
Copy link
Contributor Author

I would be happy to rename it. However, I made it plural because that matches exactly how it is in SQL Server Management Studio.

@johlju
Copy link
Member

johlju commented Oct 4, 2017

All other resources are singular and in PowerShell the norm is to use singular in all Cmdlets. So I rather see this as singular too.

@PaulFeaser
Copy link
Contributor Author

Sounds good, I will rename it.

@PaulFeaser PaulFeaser closed this Oct 5, 2017
@PaulFeaser PaulFeaser reopened this Oct 5, 2017
@PaulFeaser PaulFeaser closed this Oct 5, 2017
@johlju johlju removed the waiting for author response The pull request is waiting for the author to respond to comments in the pull request. label Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xSQLServerDatabaseDefaultLocation: New Resource
4 participants