-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xSQLServerDatabaseDefaultLocations: New Resource #854
xSQLServerDatabaseDefaultLocations: New Resource #854
Conversation
@msftclas I'm full-time Microsoft employee, not sure why it is asking for a signed CLA. |
Codecov Report
@@ Coverage Diff @@
## dev #854 +/- ##
====================================
+ Coverage 96% 96% +<1%
====================================
Files 31 32 +1
Lines 3407 3453 +46
====================================
+ Hits 3290 3336 +46
Misses 117 117 |
@PaulFeaser Contact @mbreakey3 or @kwirkykat and make sure you are in the Microsoft organisation in GitHub (think that's the problem). |
@PaulFeaser Could you please rename the resource to 'xSQLServerDatabaseDefaultLocation' (singular). Throughout the files. |
I would be happy to rename it. However, I made it plural because that matches exactly how it is in SQL Server Management Studio. |
All other resources are singular and in PowerShell the norm is to use singular in all Cmdlets. So I rather see this as singular too. |
Sounds good, I will rename it. |
Pull Request (PR) description
Created new resource for setting Database Default Locations (Data/Log/Backup) for SQL Server
This Pull Request (PR) fixes the following issues:
Fixes #656
Task list:
This change is