Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xSQLServer: Fix running tests locally in PowerShell console #898

Merged
merged 1 commit into from
Nov 4, 2017

Conversation

johlju
Copy link
Member

@johlju johlju commented Nov 3, 2017

Pull Request (PR) description

This Pull Request (PR) fixes the following issues:
Fixes #897

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

- Changes to xSQLServerEndpointPermission
  - Fixed a problem when running the tests locally in a PowerShell console it
    would ask for parameters (issue dsccommunity#897).
- Changes to xSQLServerAvailabilityGroupListener
  - Fixed a problem when running the tests locally in a PowerShell console it
    would ask for parameters (issue dsccommunity#897).
@johlju johlju force-pushed the fix-endpointpermission-tests branch from 39178b5 to faddcd1 Compare November 3, 2017 15:31
@johlju johlju added the needs review The pull request needs a code review. label Nov 3, 2017
@codecov-io
Copy link

codecov-io commented Nov 3, 2017

Codecov Report

Merging #898 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #898   +/-   ##
===================================
  Coverage    96%    96%           
===================================
  Files        32     32           
  Lines      3508   3508           
===================================
  Hits       3388   3388           
  Misses      120    120

@johlju
Copy link
Member Author

johlju commented Nov 4, 2017

:lgtm:


Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju johlju merged commit 1eddecb into dsccommunity:dev Nov 4, 2017
@vors vors removed the needs review The pull request needs a code review. label Nov 4, 2017
@johlju johlju deleted the fix-endpointpermission-tests branch December 6, 2017 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xSQLServer: Running tests locally in PowerShell console generates prompt for parameters
3 participants