BREAKING CHANGE: SqlAg & SqlReplica: Removes SQLServerNetName in favor of EndpointHostName

[johlju]

Pull Request (PR) description

• Changes to SqlAG
  • BREAKING CHANGE: The read-only property SQLServerNetName was removed in favor of EndpointHostName (issue SqlAG & SqlAGReplica: Remove parameter SQLServerNetName #924). Get-TargetResource will return the value of property NetName
    as the default value if EndpointHostName parameter is not assigned a value.
• Changes to SqlAGReplica
  • BREAKING CHANGE: The read-only property SQLServerNetName was removed in favor of EndpointHostName (issue SqlAG & SqlAGReplica: Remove parameter SQLServerNetName #924). Get-TargetResource will return the value of property NetName
    as the default value if EndpointHostName parameter is not assigned a value.

This Pull Request (PR) fixes the following issues:
Fixes #924

Task list:

• Change details added to Unreleased section of CHANGELOG.md?
• Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
• Examples appropriately updated?
• New/changed code adheres to Style Guidelines?
• Unit and (optional) Integration tests created/updated where possible?

---

This change is 

[codecov-io]

Codecov Report

Merging #938 into dev will not change coverage.
The diff coverage is 100%.

@@         Coverage Diff         @@
##            dev   #938   +/-   ##
===================================
  Coverage    96%    96%           
===================================
  Files        32     32           
  Lines      3515   3515           
===================================
  Hits       3395   3395           
  Misses      120    120

[johlju]

Reviewed 6 of 7 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

CHANGELOG.md, line 27 at r2 (raw file):

    of EndpointHostName ([issue #924](https://github.com/PowerShell/SqlServerDsc/issues/924)).
    Get-TargetResource will return the value of property [NetName](https://technet.microsoft.com/en-us/library/microsoft.sqlserver.management.smo.server.netname(v=sql.105).aspx)
    as the default value if EndpointHostName parameter is not assigned a value.

This is wrong, it will always return the NetName as the value.

---

CHANGELOG.md, line 47 at r2 (raw file):

    of EndpointHostName ([issue #924](https://github.com/PowerShell/SqlServerDsc/issues/924)).
    Get-TargetResource will return the value of property [NetName](https://technet.microsoft.com/en-us/library/microsoft.sqlserver.management.smo.server.netname(v=sql.105).aspx)
    as the default value if EndpointHostName parameter is not assigned a value.

This is wrong, it will always return the NetName as the value.

---

Comments from Reviewable

[johlju]

Review status: 6 of 7 files reviewed at latest revision, 2 unresolved discussions.

---

CHANGELOG.md, line 27 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This is wrong, it will always return the NetName as the value.

Done.

---

CHANGELOG.md, line 47 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This is wrong, it will always return the NetName as the value.

Done.

---

Comments from Reviewable

[johlju]

---

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable