-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UpdateServicesServer, UpdateServicesApprovalRule: Fixing Products processing, verbose output #64
base: main
Are you sure you want to change the base?
Conversation
I think I'll need a bit of advice on how to deal with all the failed checks, as they seem to be mostly unrelated to the changes that I made. Should I ignore them? Or do they need to be fixed first, before my changes can be accepted? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. tested->ok
Project likes dead. How can we made progression in it that the pull request are approved? |
Is this project abandoned? |
No, but I need to be reminded (on slack) or see the notifications. |
Curious if this PR will be merged? |
@NicolasBn has this been included part of your merged changes? |
@TheBlackMini or @luzkenin are you able to rebase this branch and re-submit a PR. |
@gaelcolas Indeed. To cover issue #61, I need to update |
So, @NicolasBn do I need to do anything? |
@TheBlackMini I don't have any time before next week. If you don't want to wait, you can submit your PR :) |
I worked on a solution here : Get-UpdateServicesDscProduct I created a function to find all products based on value passed on I 'just' need to use it in |
Pull Request (PR) description
UpdateServicesServer
andUpdateServicesApprovalRule
UpdateServiceServer
UpdateServicesApprovalRule
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is