Switch from timetk to slider for sliding window #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`timetk` got archived from CRAN at one point, causing this package to get archived as well. While `timetk` is back up, we only use it for a single function, and that function is basically a re-export from the lower-level `slider` package. So this removes our dependency on `timetk` and replaces it with a dependency on `slider` instead. As it turns out, this also gives us better results, since we're able to more clearly note that we're looking for a sliding window on the "time" column of 30 seconds. So the test is updated, and the results look more correct. Resolves #2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timetkgot archived from CRAN at one point, causing this package to get archived as well.While
timetkis back up, we only use it for a single function, and that function is basically a re-export from the lower-levelsliderpackage.So this removes our dependency on
timetkand replaces it with a dependency onsliderinstead.As it turns out, this also gives us better results, since we're able to more clearly note that we're looking for a sliding window on the "time" column of 30 seconds. So the test is updated, and the results look more correct.
Resolves #3