-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structure cleanup #187
Structure cleanup #187
Conversation
and move its subdirectories including locale, schemas and ui to the root of the repo.
When building, the metadata.json in src/ directory (previously named [email protected]/) was being replaced in the resulting ZIP file. Remove it.
Update README.markdown to point to the renamed image.
Move all <lang-code>/LC_MESSAGES/coverflow.po files to <lang-code>.po files.
Use gnome-extensions tool to create an extension bundle.
Remove support for system-wide installation and uninstallation of the extension.
I see you deleted the buildforupload.sh. The zip command there excluded some files from the archive (e.g. the .po files). Please make sure the new make build command provides the same exclusions and includes the same files (gschema.compiled, *.mo files), because those exclusions were required for acceptance on extensions.gnome.org. |
@p91paul, I tested it already, |
Thank you for your clarification. I reviewed the pr from my phone and did not know what the pack command did 💪 |
@p91paul any objection to merging? If not, I will! |
no objection whatsoever, thanks to the both of you for the good work on this project. |
Closes #186.
The only thing that is removed during the process is the
LOCALINSTALL
feature. Many extensions do not support this way of installation, plus it's uncommon between users to install the extension into/usr/local
. By the way, if you think it's necessary, it's relatively easy to bring it back.BTW, I don't get the point of
*install_schema_systemwide
make jobs.The new build process is done by
make build
, which creates a zip file in thebuild/
directory.Many of the binary files have been removed, including unused images,
gschema.compiled
and.mo
files. The compiled binaries should only be made at the build stage, and shouldn't be tracked in the repository itself.Also, updated po files, improved
Makefile
, and other small changes.