Skip to content

Commit

Permalink
Use a specific name for SCC
Browse files Browse the repository at this point in the history
There are some tests [1] that fail because the SCC name is too large.
The SCC name when the aot test flag is set is derived from the test
name. In order to prevent this issue, simply use the same name for all
tests. This is ok because prior to and after running tests, all SCCs are
destroyed. Additionally, this does not impact any future ability to run
tests in parallel as this is already not possible; the fact that all
SCCs are destroyed between tests means that test could impact the
validity of another.

[1] eclipse-openj9/openj9#14461

Signed-off-by: Irwin D'Souza <[email protected]>
  • Loading branch information
dsouzai committed Feb 9, 2022
1 parent 46b8192 commit e2d9fd6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion featureSettings.mk
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ ifneq (,$(findstring AOT,$(TEST_FLAG)))
export TR_silentEnv=1
export TR_Options=forceAOT
export TR_OptionsAOT=forceAOT
AOT_OPTIONS = -Xshareclasses:name=$@ -Xscmx400M -Xscmaxaot256m
AOT_OPTIONS = -Xshareclasses:name=test_aot -Xscmx400M -Xscmaxaot256m
ifndef TEST_ITERATIONS
TEST_ITERATIONS = 2
endif
Expand Down

0 comments on commit e2d9fd6

Please sign in to comment.