Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Show all jobs in runs UI #1723

Closed
Tracked by #1782
jvstme opened this issue Sep 24, 2024 · 4 comments · Fixed by #1887 or #1923
Closed
Tracked by #1782

[Feature]: Show all jobs in runs UI #1723

jvstme opened this issue Sep 24, 2024 · 4 comments · Fixed by #1887 or #1923

Comments

@jvstme
Copy link
Collaborator

jvstme commented Sep 24, 2024

Problem

The runs list page (/runs) and run details page (/projects/<project>/runs/<run>) only show details about one job from the run: backend, region, instance ID, price, etc. If the run has multiple jobs, the user cannot see details or logs of other jobs.

Showing details of a single jobs as details of the whole run can also be misleading, e.g. the price shown in the UI looks like the price of the whole run, while it is actually the price of only one job - only part of the run's price.

Solution

On the runs list page (/runs), show all jobs of each run, e.g. the way they are shown in CLI:

> dstack ps -w
 NAME         BACKEND  REGION     RESOURCES                   SPOT  PRICE    STATUS        SUBMITTED   
 single-node  aws      us-west-2  1xCPU, 2GB, 100.0GB (disk)  yes   $0.0059  provisioning  1 min ago   
 multi-node                                                                  running       5 mins ago  
   replica 0  aws      us-west-2  1xCPU, 2GB, 100.0GB (disk)  yes   $0.0059  running       5 mins ago  
   job_num 0                                                                                           
   replica 0  aws      us-west-2  1xCPU, 2GB, 100.0GB (disk)  yes   $0.0059  done          5 mins ago  
   job_num 1                                                                                           
 httpbin                                                                     running       11 mins ago 
   replica 0  aws      us-west-2  1xCPU, 2GB, 100.0GB (disk)  yes   $0.0059  running       11 mins ago 
   job_num 0                                                                                           
   replica 1  aws      us-west-2  1xCPU, 2GB, 100.0GB (disk)  yes   $0.0059  running       11 mins ago 
   job_num 0                                                                                           

On the run details page (/projects/<project>/runs/<run>), show the run details at the top and details for each job separately below.

Show logs per-job too.

Additional information

The API seems to already provide all the data, so changes are only needed in frontend.

@peterschmidt85
Copy link
Contributor

Still would like to better understand the use case

@jvstme
Copy link
Collaborator Author

jvstme commented Sep 25, 2024

@peterschmidt85, some examples:

  • A multi-replica service is running and I need to know it's whole price, not the price of a single job. I don't have access to CLI at the moment.
  • I need to verify in which region each replica is running. I don't have access to CLI at the moment.
  • One of the jobs failed and I need to see its logs.
  • many more

@r4victor r4victor mentioned this issue Oct 4, 2024
49 tasks
olgenn added a commit that referenced this issue Oct 21, 2024
Improvements for runs list
olgenn added a commit that referenced this issue Oct 23, 2024
Improvements for run details
Create job details page
olgenn added a commit that referenced this issue Oct 23, 2024
* Show all jobs in runs UI #1723
Improvements for runs list

* Show all jobs in runs UI #1723
Improvements for run details
Create job details page
@jvstme
Copy link
Collaborator Author

jvstme commented Oct 24, 2024

@olgenn, thank you! A few comments:

  • Can we please add the dollar sign ($) to multi-job run prices? Both in the runs list and on the run details page.
    dollar
  • On the run details page, is it possible to hide the fields that are irrelevant for multi-job runs instead of putting a dash (-) in them?
    irrelevant
  • Can we please display these job properties:
    • Status - both on the job details page and in the jobs list. If a new column doesn't fit in the jobs list, we could sacrifice the "Instance" column
    • Submitted - on the job details page + preferably in the jobs list if it fits there
    • Termination reason - only on the job details page, the value should be capitalized

@jvstme jvstme reopened this Oct 24, 2024
@olgenn
Copy link
Collaborator

olgenn commented Oct 30, 2024

Fixed in 454b18e

olgenn added a commit that referenced this issue Oct 30, 2024
* [Bug]: [UI] Dark YAML editor theme won't work #1921

* Show all jobs in runs UI #1723
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants