Changed dstack pool remove to rm [Issue #1256]
#1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @muddi900! Shall we add a command alias for users that are still using the old command? |
jvstme
approved these changes
May 21, 2024
There was a problem hiding this comment.
There was some unrelated reformatting, which probably means the file was formatted with a tool other than ruff format, which is what we use. I reverted the reformatting just so that the diff is more concise.
Other than that, everything looks good to me. Thanks, @muddi900!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1256
I couldn't run any tests because I don't know the dep management situation. But the arg has been renamed.