Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support gateways behind ALB with ACM certificate #1264

Merged
merged 2 commits into from
May 23, 2024

Conversation

r4victor
Copy link
Collaborator

@r4victor r4victor commented May 22, 2024

Closes #1257

This PR:

  • Adds certificate field to gateway configuration. Users can specify lets-encrypt for automatic certificates, acm for AWS Certificate Manager certificates, or None for gateways without certificates that will run only http services.
  • Add support for provisioning AWS gateways behind ALB to support ACM certificates. Users will point the domain to the ALB DNS name – the gateways now have hostname property that is either a dns name or an IP address.

This allows users to run https services on AWS gateways without public IPs. Note that users can also use AWS Certificate Manager certificates with public gateways. dstack provisions either internal or internet-facing ALB to support both cases.

Example configuration for provisioning private gateway with https support:

type: gateway
name: test-aws-gateway
backend: aws
region: eu-central-1
domain: 'example.com'
public_ip: False
default: True
certificate:
  type: acm
  arn: 'arn:...'

TODO:

  • Allow updating ACM certificate for renewal

@r4victor r4victor mentioned this pull request May 22, 2024
41 tasks
@r4victor r4victor merged commit 576d1af into master May 23, 2024
15 checks passed
@peterschmidt85 peterschmidt85 mentioned this pull request Jun 24, 2024
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support provisioning gateways with SSL certificates issues with ACM
1 participant