Support gateways behind ALB with ACM certificate #1264
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1257
This PR:
certificate
field to gateway configuration. Users can specifylets-encrypt
for automatic certificates,acm
for AWS Certificate Manager certificates, or None for gateways without certificates that will run only http services.This allows users to run https services on AWS gateways without public IPs. Note that users can also use AWS Certificate Manager certificates with public gateways. dstack provisions either
internal
orinternet-facing
ALB to support both cases.Example configuration for provisioning private gateway with https support:
TODO: