Fix nvidia-smi not available on lambda #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1356
The PR fixes nvidia docker runtime not working on lambda instances.
The issue took place because we installed
nvidia-docker2on lambda instances which is deprecated and doesn't work for the docker version shipped on lambda (24.0.7) . To enable nvidia in docker,nvidia-container-toolkitis now recommended. The fix replacesnvidia-docker2withnvidia-container-toolkit.See NVIDIA/nvidia-docker#1268 (comment) for more details.
In other backends where dstack uses its own VM images, docker 20.10.17 is installed which apparently still works with
nvidia-docker2. We should consider migrating tonvidia-container-toolkiteverywhere when updating the docker version.Also, the PR refactors LambdaBackend to implement
update_provisioning_data()to fix long waiting for ip address in create_instance() that lead to the blocking of jobs processing.