Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TPUs fixes #1360

Merged
merged 3 commits into from
Jun 26, 2024
Merged

TPUs fixes #1360

merged 3 commits into from
Jun 26, 2024

Conversation

r4victor
Copy link
Collaborator

@r4victor r4victor commented Jun 26, 2024 •
edited
Loading

The PR introduces several TPU fixes:

  • TPU creation may took a long time leading to long create_instance(). The PR refactors GCP to implement update_provisioning_data() to return from create_instance() ASAP.
  • Handling of TPU being interrupted right after creation.
  • Respect public_ips=False for TPU.

@r4victor r4victor merged commit 3e89218 into master Jun 26, 2024
15 checks passed
@r4victor r4victor deleted the fix_tpus branch June 26, 2024 11:25
@jvstme jvstme mentioned this pull request Jul 2, 2024
Closed
@r4victor r4victor mentioned this pull request Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@r4victor