Support AWS placement groups for cluster fleets #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1715
With this PR, instances in AWS fleets with
placement: clusterwill be grouped in cluster placement groups to provide better connectivity.Note that placement groups are not used when running multi-node tasks without first creating a cluster fleet. (We'll see if it should be implemented too).
Fleet example:
The dstack server creates and deletes placement groups transparently for users. A placement group is created when the first fleet instance is provisioned and deleted by a background task after the fleet is deleted and there are no more instances in the group.