Skip to content

Commit

Permalink
Per #2106, not including 'shape' in the shared variable list causes a…
Browse files Browse the repository at this point in the history
… compilation error in GCC9.

data_plane_util.cc:262:36: error: "shape" not specified in enclosing "parallel"

However, including it causes a compilation error in GCC8!

data_plane_util.cc:257:38: error: 'shape' is predetermined 'shared' for 'shared'
    private(x, y, n_vld, n_thr, gp, v)

Try making "shape" non-const to see if that sidesteps the GCC8 issue.
  • Loading branch information
JohnHalleyGotway committed Apr 4, 2022
1 parent 94a1482 commit fbd5978
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions met/src/basic/vx_util/data_plane_util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ using namespace std;

#include "GridTemplate.h"


////////////////////////////////////////////////////////////////////////
//
// Utility functions operating on a DataPlane
Expand Down Expand Up @@ -206,7 +205,7 @@ DataPlane smooth_field(const DataPlane &dp,
////////////////////////////////////////////////////////////////////////

void fractional_coverage(const DataPlane &dp, DataPlane &frac_dp,
int width, const GridTemplateFactory::GridTemplates shape,
int width, GridTemplateFactory::GridTemplates shape,
bool wrap_lon, SingleThresh t,
const DataPlane *cmn, const DataPlane *csd, double vld_t) {
GridPoint *gp = NULL;
Expand Down
2 changes: 1 addition & 1 deletion met/src/basic/vx_util/data_plane_util.h
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ extern DataPlane smooth_field(const DataPlane &dp,
bool wrap_lon, double t, const GaussianInfo &gaussian);

extern void fractional_coverage(const DataPlane &dp, DataPlane &frac_dp,
int width, const GridTemplateFactory::GridTemplates shape,
int width, GridTemplateFactory::GridTemplates shape,
bool wrap_lon, SingleThresh t,
const DataPlane *cmn, const DataPlane *csd, double vld_t);

Expand Down

0 comments on commit fbd5978

Please sign in to comment.