Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Ensemble-Stat, Point-Stat, Plot-Point-Obs, and Point2Grid to support python embedding of point observations. #1844

Closed
6 of 21 tasks
j-opatz opened this issue Jun 23, 2021 · 6 comments · Fixed by #2010
Assignees
Labels
MET: Python Embedding priority: blocker Blocker requestor: NOAA/CPC NOAA Climate Prediction Center requestor: NOAA/OPC NOAA Ocean Prediction Center requestor: UK Met Office United Kingdom Met Office required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: new feature Make it do something new
Milestone

Comments

@j-opatz
Copy link
Contributor

j-opatz commented Jun 23, 2021

Describe the New Feature

This issue was originally titled "Allow read into memory for Point2Grid". However this feature request should be done as part of a larger task to more broadly support python embedding of point observations across multiple tools. Currently, this type of python embedding is only supported in ascii2nc. This task is to expand that support to include point_stat, ensemble_stat, point2grid, and plot_point_obs. I believe those are all the tools which read the NetCDF point observation files written by the *2NC point pre-processing tools. If needed, consider breaking this issue out into separate ones for each of those tools. Make sure that the conventions for requesting python embedding of point observations are as consistent as possible across these tools.

Currently, The MET user's guide states the Point2Grid tool "...takes point observations from a NetCDF output file from one of the four previously mentioned MET tools (ascii2nc, madis2nc, pb2nc, lidar2nc) and creates a gridded NetCDF file." The original workflow did not take advantage of the Python embedding, which is now prevalent in MET.

A recent use case highlighted the cumbersome task of converting an ASCII file to a grid for analysis, via (ASCII2NC w/ Python Embedding) --> (Point2Grid) --> (GridStat). The ASCII2NC tool creates netCDF files each time it runs, but since these files are immediately passed into Point2Grid, they only take up disk space and are unwanted by the user.

The desire is for the Point2Grid tool to no longer require a file input when it is a tool called in a series of tools (as described above). Instead, Point2Grid should be able to utilize a file or point data from a memory-read list which the user provides via Python embedding.

Acceptance Testing

An ASCII file of any amount of point data will suffice for testing. @j-opatz can provide an example file and companion Python script if required.
The successful resolution of this issue will be Point2Grid being able to read in point data from memory.

Time Estimate

Need input from engineer

Sub-Issues

Consider breaking the new feature down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

None

Funding Source

2788881 (do not charge as of 16Dec21)
Instead split 2792541, 2702691, 2799991, 2700042,

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

New Feature Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@j-opatz j-opatz added type: new feature Make it do something new priority: high requestor: NOAA/CPC NOAA Climate Prediction Center required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone MET: Python Embedding labels Jun 23, 2021
@j-opatz j-opatz added this to the MET 10.1.0 milestone Jun 23, 2021
@JohnHalleyGotway JohnHalleyGotway changed the title Allow read into memory for Point2Grid Add support for python embedding of point observations to all of the MET tools. Jul 29, 2021
@JohnHalleyGotway JohnHalleyGotway changed the title Add support for python embedding of point observations to all of the MET tools. Add support for python embedding of point observations to MET tools that process them. Jul 29, 2021
@TaraJensen TaraJensen added the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Sep 13, 2021
@TaraJensen TaraJensen removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Oct 21, 2021
@TaraJensen TaraJensen added required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project priority: blocker Blocker and removed priority: high required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone labels Dec 9, 2021
@TaraJensen TaraJensen added requestor: NOAA/OPC NOAA Ocean Prediction Center requestor: UK Met Office United Kingdom Met Office labels Dec 9, 2021
@TaraJensen
Copy link
Contributor

As per our discussion on 12/9/21 - This capability would be very helpful to assess if Python-embedding using Met Office's VARPy code to read ODB might be efficient enough or optimizable enough to work for operational verification. If it isn't, then we might have to develop the C++ interface, which will be substantial work.

hsoh-u pushed a commit that referenced this issue Dec 28, 2021
hsoh-u pushed a commit that referenced this issue Dec 29, 2021
@hsoh-u hsoh-u linked a pull request Dec 29, 2021 that will close this issue
14 tasks
hsoh-u pushed a commit that referenced this issue Dec 29, 2021
hsoh-u pushed a commit that referenced this issue Jan 13, 2022
hsoh-u pushed a commit that referenced this issue Jan 13, 2022
hsoh-u pushed a commit that referenced this issue Jan 13, 2022
@hsoh-u hsoh-u linked a pull request Jan 13, 2022 that will close this issue
14 tasks
hsoh-u pushed a commit that referenced this issue Jan 21, 2022
@hsoh-u hsoh-u closed this as completed Jan 26, 2022
JohnHalleyGotway added a commit that referenced this issue Feb 3, 2022
* Per #1906, modify code to pass entire path to make_temp_file_name instead of only the filename so that the function can tell whether or not the file exists. (#1952)

Co-authored-by: Julie Prestopnik <[email protected]>

* Feature 1761 percent thresh (#1956)

* Per issue #1761 in set_perc() adding code to get FBIAS numeric value, like 1.0 or 0.9, etc. SL

* Per issue #1761: in set_perc(), modified actual percentile calculation at end to use the extracted FBIAS numeric value (float). SL

* Per issue #1761: modified the check on the perc_thresh_freq_bias, just has to be > 0 now. SL

* Per issue #1761: cleaned up code in set_perc(). SL

* Per #1761, updates to Simple_Node::set_perc() to handle variable frequency bias amounts.
Changes include:
- Reverting the formatting of this back to how it originally was in the develop branch. In general, just match the formatting of the existing file, so as the minimize the number of difference lines.
- Add logic to adjust the percentile to be found based on the requested FBIAS value. Multiplying or dividing the percentile by the FBIAS value depends on the inequality type and whether we're bias adjusting the forecast or observation data.
- Adjust the log messages slightly.

Please be aware that I'm not totally confident in these changes. They warrant much more testing. This logic is very, very confusing.

* Per #1761, call compute_percentile() when double-checking the percentile values.

* Per #1761, remove unused variable.

* Per #1761, add warning for percentiles > 100.

* Per #1761. In set_perc(), after testing cleaned up code. SL

* Per issue #1761: adding new config file for testing dynamic FBIAS values. SL

* Per issue #1761: added new unit test for dynamic FBIAS values when running grid_stat. SL

* Per issue #1761, modified FBIAS section to indicated that the user can use dynamic values that are not 1.0. SL

* Update met/docs/Users_Guide/config_options.rst

Co-authored-by: johnhg <[email protected]>

* Update met/docs/Users_Guide/config_options.rst

Co-authored-by: johnhg <[email protected]>

* Update met/docs/Users_Guide/config_options.rst

Co-authored-by: johnhg <[email protected]>

* Update test/config/GridStatConfig_fbias_perc_thresh

Co-authored-by: johnhg <[email protected]>

* Update test/config/GridStatConfig_fbias_perc_thresh

Co-authored-by: johnhg <[email protected]>

* Update test/config/GridStatConfig_fbias_perc_thresh

Co-authored-by: johnhg <[email protected]>

* Update test/config/GridStatConfig_fbias_perc_thresh

Co-authored-by: johnhg <[email protected]>

* Per issue #1761, set nc_pairs_flag = FALSE. SL

Co-authored-by: Seth Linden <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>

* Feature 1905 ens_ctrl (#1955)

Co-authored-by: j-opatz <[email protected]>

* Hotfix after merging changing for #1761. Updating the list of expected output files.

* Per #1905, committing a hotfix directly to the develop branch. Reverting the logic for computing the ensemble range back to what it was previously. The new version produced very slight differences in the 6-th or 7-th decimal place when compared to previous results. There's not good reason for these changes which were caused by the order of operations in casting from doubles to floats. Reverting back to the old logic prevents diffs for anyone else downstream and is the prudent choice.

* Feature 1957 ascii2nc_python (#1958)

* Feature 1949 cf netcdf documentaton (#1951)

* #1949 Added CF compliant NetCDF into data IO

* #1949 Added commas

* #1948 Some corrections for typo and added the links for CF attributes

* #1948 Added Performance with NetCDF input data

* #1949 Corrected tyoe and applied Juloie's suggestions

Co-authored-by: Howard Soh <[email protected]>

* Feature 1968 ens_ctrl (#1969)

* Feature 1809 gen prob (#1967)

* Feature 1970 v10.1.0-beta4 (#1973)

* Fix tiny typo in plot_data_plane usage statement.

* Hotfix for the develop branch to get met-10.1.0-beta4 compiling on WCOSS. The intel compiler does not allow adjacent >> characters when defining maps.

* Updating the beta4 release date from 11/16 to 11/17 since the beta4 release needs to be recreated.

* Update the MET PR template to list expected changes up front.

* Bugfix 1976 develop cdist (#1979)

* #1936 Excludes precip3hr, precip6hr, precip12hr, and precip10min from required variables for MESONET

* Per #1985, correcting typo found while creating V10.0.1 in the develop branch as well.

* Per #1985, VERY minor change to fix alignment of titles in Point-Stat... updating the develop branch.

* #1936 Added an unit test for newer MESONET file

* Feature 1989 sort (#1990)

* Feature 1991 VCNT (#1992)

* Feature 1993 grid_mask (#1994)

* #1844 Added vx_pointdata_python

* #1844 Added vx_pointdata_python to PYTHON_LIBS & make file for vx_pointdata_python

* #1844 Added vx_pointdata_python to SUBDIRS

* #1844 Initial release

* #1844 Added met_point_data.cc & met_point_data.h

* #1844 NcHeaderData is renamed to MetPointHeader and moved to met_point_dataq.h

* #1844 NcPointObsData is derived from MetPointObsData. Many methods are moved to the base class MetPointObsData

* #1844 Moved varianbles and methods to the base class MetPointData

* #1844 override the obs_data pointer to the derived class

* #1844 Added pyobject_as_bool & pyobject_as_string_array

* #1844 Cleanup include statements and addpointdata_python.h if python is enabled

* #18443 Support python embedding

* #1844 Initial release

* #1844 Make buf_size const

* Add GitHub Actions workflow to trigger METplus testing workflow (#2002)

* changed names of inputs to send to METplus to match changes to METplus repo

* #1965 Excludes the duplicated variable names from multiple input files

* #1965 Processed with the raw variable names and update them when the output is saved.

* #1965 Added unit test ioda2nc_same_input

* #1965 Processed with the raw variable names and update them when the output is saved.

* #1965 Added unit test ioda2nc_same_input

* #1965 initialize var_idx

* Update the development environment for seneca to add /usr/local/nco/bin and /usr/local/netcdf/bin to the path. Also define MET_TEST_RSCRIPT to point to a new enough version of RSCRIPT that has the ncdf4 package 1.17 or later.

* send email address of user who triggered event to METplus workflow as input

* Fixup the Rscript diffing logic to support running the nightly build on seneca. The problem here is that the ncdiff -x -v command line options that worked in version 4.7.0 NO LONGER work in 4.9.2. Added a check to skip over the time_bounds variable when processing the ncdiff output.

* No real changes here. Just formatting

* Feature 1974 message_type_group_map (#1999)

Co-authored-by: Howard Soh <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>

* Feature 1996 uninitialized variables (#2004)

Co-authored-by: Howard Soh <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>

* Feature 1695 ensemble single file (gen_ens_prod) (#2001)

Co-authored-by: johnhg <[email protected]>

* Feature 1965 NB faile with time summary by ioda2nc (#2008)

Co-authored-by: Howard Soh <[email protected]>

* Feature 1810 shapes (#2005)

* #1844 Added log message for use_var_id

* #1844 Get use_var_id for python embedding

* #1844 Initial release

* #1844 Added met_point_obs.py and read_met_point_obs.py

* #1844 Added 4 unit test for python embedding of MET point data

* More changes to test_util.R to account for differences between 4.7.0 and 4.9.2 of ncdiff. The earlier version reported 0 diffs for the time_bounds, lat, lon, latitude, and longitude variables while the newer version reports their raw values. Simply ignore these variables for now. This isn't a great solution but when we reimplement this testing logic in python, we can address this issue then.

* #1844 Added python embedding for point observation data

* Feature 1926 gridstat openmp (#1977)

Co-authored-by: johnhg <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>
Co-authored-by: Julie Prestopnik <[email protected]>

* feature 1695 ensemble single file (ensemble_stat) (#2007)

Co-authored-by: johnhg <[email protected]>

* Committing directly to the develop branch. Removing many, many instances of MET_BUILD_BASE and a couple instances of MET_BASE from the examples listed in Appendix A. The inconsistent use of these variables will only cause confusion. Removing them will help avoid that confusion. Big picture... MET_BASE defines the installed 'share/met' directory. It can be used to reference the location of map or polyline files. MET_BUILD_BASE is only used in the context of the test scripts. There, it's defined as the top-level source code directory in which the code was compiled. Its used to reference the location of sample data files or Rscript included in the tarball. I left a couple references to these variables in Appendix A where thier use is not confusing. But I removed all instances which are used to the define the location of the 'bin' directory. Instead, let's just assume the MET binaries are already in their path... or the user knows where to find them.

* feature 2011 v10.1.0-beta5 (#2014)

* feature 1695 fix issues with ensemble changes (#2012)

Co-authored-by: John Halley Gotway <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>

* Hotfix for #1695 committed directly to the develop branch. The new Ensemble-Stat config files added for this issue don't define a random number generator seed. This results in different output for each run and prevents the regression test from producing repeatable results. Defining the seed here to fix that.

* Adding George to email list for the nightly build.

* Fix the links for the met-10.1.0-beta5 release notes.

* #1844 Make met_point_obs as abstract class

* #1844 correctedb for loop end condition on processing obs bdata

* Feature 1546 unit_tests (#2021)

* #2020 Added SonarQube related varibales

* #2020 Initial release

* #2015 Avoid the repeasted debug message if derived varibales are disabled

* #1996 Initialize right and left

* #1966 Call clear() instead of reset memory for Header variable

* #1966 Make sure the levels from variable  does not exceed the maxLevel

* #1966 Removed unreachable codes

* #1966 Do not write into NetcDF if empty data

* #2015 Corrected "retained or derived" count

* Feature 1546 CI testing (#2029)

Co-authored-by: John Halley Gotway <[email protected]>

* fixed broken workflow by setting environment variable expected for docker build script

* add missing docker tag from push command

* added correct docker tag value

* fixed incorrect truth data version for updating -ref reference data

* Updating develop with changes to the unit tests names. Renaming unit_test.yml to a more generic testing.yml name since it compiles AND/OR runs unit tests. Also make the job names more concise so its easier to see what's running in the action summary window on GitHub.

* fixed directory to copy truth data into -- copy command was copying the content of the directory, not including the directory itself

* Per #1907, added warning about switch from Ensemble-Stat to Gen-Ens-Prod (#2032)

Co-authored-by: Julie Prestopnik <[email protected]>

* 2028 Check null for header data

* Removed un-reachable code

* #2028 Check if the pointer (d) is null

* #2015 Changed warning to debug message

* #2028 Passing two dimensionl cur and dim array

* #2028 Set obs_data

* Feature 2003 briercl (#2034)

Co-authored-by: jprestop <[email protected]>
Co-authored-by: Julie Prestopnik <[email protected]>
Co-authored-by: Seth Linden <[email protected]>
Co-authored-by: Seth Linden <[email protected]>
Co-authored-by: j-opatz <[email protected]>
Co-authored-by: hsoh-u <[email protected]>
Co-authored-by: Howard Soh <[email protected]>
Co-authored-by: George McCabe <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>
Co-authored-by: MET Tools Test Account <[email protected]>
Co-authored-by: mo-mglover <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>
Co-authored-by: Howard Soh <[email protected]>
JohnHalleyGotway added a commit that referenced this issue Feb 12, 2022
* Per #1906, modify code to pass entire path to make_temp_file_name instead of only the filename so that the function can tell whether or not the file exists. (#1952)

Co-authored-by: Julie Prestopnik <[email protected]>

* Feature 1761 percent thresh (#1956)

* Per issue #1761 in set_perc() adding code to get FBIAS numeric value, like 1.0 or 0.9, etc. SL

* Per issue #1761: in set_perc(), modified actual percentile calculation at end to use the extracted FBIAS numeric value (float). SL

* Per issue #1761: modified the check on the perc_thresh_freq_bias, just has to be > 0 now. SL

* Per issue #1761: cleaned up code in set_perc(). SL

* Per #1761, updates to Simple_Node::set_perc() to handle variable frequency bias amounts.
Changes include:
- Reverting the formatting of this back to how it originally was in the develop branch. In general, just match the formatting of the existing file, so as the minimize the number of difference lines.
- Add logic to adjust the percentile to be found based on the requested FBIAS value. Multiplying or dividing the percentile by the FBIAS value depends on the inequality type and whether we're bias adjusting the forecast or observation data.
- Adjust the log messages slightly.

Please be aware that I'm not totally confident in these changes. They warrant much more testing. This logic is very, very confusing.

* Per #1761, call compute_percentile() when double-checking the percentile values.

* Per #1761, remove unused variable.

* Per #1761, add warning for percentiles > 100.

* Per #1761. In set_perc(), after testing cleaned up code. SL

* Per issue #1761: adding new config file for testing dynamic FBIAS values. SL

* Per issue #1761: added new unit test for dynamic FBIAS values when running grid_stat. SL

* Per issue #1761, modified FBIAS section to indicated that the user can use dynamic values that are not 1.0. SL

* Update met/docs/Users_Guide/config_options.rst

Co-authored-by: johnhg <[email protected]>

* Update met/docs/Users_Guide/config_options.rst

Co-authored-by: johnhg <[email protected]>

* Update met/docs/Users_Guide/config_options.rst

Co-authored-by: johnhg <[email protected]>

* Update test/config/GridStatConfig_fbias_perc_thresh

Co-authored-by: johnhg <[email protected]>

* Update test/config/GridStatConfig_fbias_perc_thresh

Co-authored-by: johnhg <[email protected]>

* Update test/config/GridStatConfig_fbias_perc_thresh

Co-authored-by: johnhg <[email protected]>

* Update test/config/GridStatConfig_fbias_perc_thresh

Co-authored-by: johnhg <[email protected]>

* Per issue #1761, set nc_pairs_flag = FALSE. SL

Co-authored-by: Seth Linden <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>

* Feature 1905 ens_ctrl (#1955)

Co-authored-by: j-opatz <[email protected]>

* Hotfix after merging changing for #1761. Updating the list of expected output files.

* Per #1905, committing a hotfix directly to the develop branch. Reverting the logic for computing the ensemble range back to what it was previously. The new version produced very slight differences in the 6-th or 7-th decimal place when compared to previous results. There's not good reason for these changes which were caused by the order of operations in casting from doubles to floats. Reverting back to the old logic prevents diffs for anyone else downstream and is the prudent choice.

* Feature 1957 ascii2nc_python (#1958)

* Feature 1949 cf netcdf documentaton (#1951)

* #1949 Added CF compliant NetCDF into data IO

* #1949 Added commas

* #1948 Some corrections for typo and added the links for CF attributes

* #1948 Added Performance with NetCDF input data

* #1949 Corrected tyoe and applied Juloie's suggestions

Co-authored-by: Howard Soh <[email protected]>

* Feature 1968 ens_ctrl (#1969)

* Feature 1809 gen prob (#1967)

* Feature 1970 v10.1.0-beta4 (#1973)

* Fix tiny typo in plot_data_plane usage statement.

* Hotfix for the develop branch to get met-10.1.0-beta4 compiling on WCOSS. The intel compiler does not allow adjacent >> characters when defining maps.

* Updating the beta4 release date from 11/16 to 11/17 since the beta4 release needs to be recreated.

* Update the MET PR template to list expected changes up front.

* Bugfix 1976 develop cdist (#1979)

* #1936 Excludes precip3hr, precip6hr, precip12hr, and precip10min from required variables for MESONET

* Per #1985, correcting typo found while creating V10.0.1 in the develop branch as well.

* Per #1985, VERY minor change to fix alignment of titles in Point-Stat... updating the develop branch.

* #1936 Added an unit test for newer MESONET file

* Feature 1989 sort (#1990)

* Feature 1991 VCNT (#1992)

* Feature 1993 grid_mask (#1994)

* #1844 Added vx_pointdata_python

* #1844 Added vx_pointdata_python to PYTHON_LIBS & make file for vx_pointdata_python

* #1844 Added vx_pointdata_python to SUBDIRS

* #1844 Initial release

* #1844 Added met_point_data.cc & met_point_data.h

* #1844 NcHeaderData is renamed to MetPointHeader and moved to met_point_dataq.h

* #1844 NcPointObsData is derived from MetPointObsData. Many methods are moved to the base class MetPointObsData

* #1844 Moved varianbles and methods to the base class MetPointData

* #1844 override the obs_data pointer to the derived class

* #1844 Added pyobject_as_bool & pyobject_as_string_array

* #1844 Cleanup include statements and addpointdata_python.h if python is enabled

* #18443 Support python embedding

* #1844 Initial release

* #1844 Make buf_size const

* Add GitHub Actions workflow to trigger METplus testing workflow (#2002)

* changed names of inputs to send to METplus to match changes to METplus repo

* #1965 Excludes the duplicated variable names from multiple input files

* #1965 Processed with the raw variable names and update them when the output is saved.

* #1965 Added unit test ioda2nc_same_input

* #1965 Processed with the raw variable names and update them when the output is saved.

* #1965 Added unit test ioda2nc_same_input

* #1965 initialize var_idx

* Update the development environment for seneca to add /usr/local/nco/bin and /usr/local/netcdf/bin to the path. Also define MET_TEST_RSCRIPT to point to a new enough version of RSCRIPT that has the ncdf4 package 1.17 or later.

* send email address of user who triggered event to METplus workflow as input

* Fixup the Rscript diffing logic to support running the nightly build on seneca. The problem here is that the ncdiff -x -v command line options that worked in version 4.7.0 NO LONGER work in 4.9.2. Added a check to skip over the time_bounds variable when processing the ncdiff output.

* No real changes here. Just formatting

* Feature 1974 message_type_group_map (#1999)

Co-authored-by: Howard Soh <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>

* Feature 1996 uninitialized variables (#2004)

Co-authored-by: Howard Soh <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>

* Feature 1695 ensemble single file (gen_ens_prod) (#2001)

Co-authored-by: johnhg <[email protected]>

* Feature 1965 NB faile with time summary by ioda2nc (#2008)

Co-authored-by: Howard Soh <[email protected]>

* Feature 1810 shapes (#2005)

* #1844 Added log message for use_var_id

* #1844 Get use_var_id for python embedding

* #1844 Initial release

* #1844 Added met_point_obs.py and read_met_point_obs.py

* #1844 Added 4 unit test for python embedding of MET point data

* More changes to test_util.R to account for differences between 4.7.0 and 4.9.2 of ncdiff. The earlier version reported 0 diffs for the time_bounds, lat, lon, latitude, and longitude variables while the newer version reports their raw values. Simply ignore these variables for now. This isn't a great solution but when we reimplement this testing logic in python, we can address this issue then.

* #1844 Added python embedding for point observation data

* Feature 1926 gridstat openmp (#1977)

Co-authored-by: johnhg <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>
Co-authored-by: Julie Prestopnik <[email protected]>

* feature 1695 ensemble single file (ensemble_stat) (#2007)

Co-authored-by: johnhg <[email protected]>

* Committing directly to the develop branch. Removing many, many instances of MET_BUILD_BASE and a couple instances of MET_BASE from the examples listed in Appendix A. The inconsistent use of these variables will only cause confusion. Removing them will help avoid that confusion. Big picture... MET_BASE defines the installed 'share/met' directory. It can be used to reference the location of map or polyline files. MET_BUILD_BASE is only used in the context of the test scripts. There, it's defined as the top-level source code directory in which the code was compiled. Its used to reference the location of sample data files or Rscript included in the tarball. I left a couple references to these variables in Appendix A where thier use is not confusing. But I removed all instances which are used to the define the location of the 'bin' directory. Instead, let's just assume the MET binaries are already in their path... or the user knows where to find them.

* feature 2011 v10.1.0-beta5 (#2014)

* feature 1695 fix issues with ensemble changes (#2012)

Co-authored-by: John Halley Gotway <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>

* Hotfix for #1695 committed directly to the develop branch. The new Ensemble-Stat config files added for this issue don't define a random number generator seed. This results in different output for each run and prevents the regression test from producing repeatable results. Defining the seed here to fix that.

* Adding George to email list for the nightly build.

* Fix the links for the met-10.1.0-beta5 release notes.

* #1844 Make met_point_obs as abstract class

* #1844 correctedb for loop end condition on processing obs bdata

* Feature 1546 unit_tests (#2021)

* #2020 Added SonarQube related varibales

* #2020 Initial release

* #2015 Avoid the repeasted debug message if derived varibales are disabled

* #1996 Initialize right and left

* #1966 Call clear() instead of reset memory for Header variable

* #1966 Make sure the levels from variable  does not exceed the maxLevel

* #1966 Removed unreachable codes

* #1966 Do not write into NetcDF if empty data

* #2015 Corrected "retained or derived" count

* Feature 1546 CI testing (#2029)

Co-authored-by: John Halley Gotway <[email protected]>

* fixed broken workflow by setting environment variable expected for docker build script

* add missing docker tag from push command

* added correct docker tag value

* fixed incorrect truth data version for updating -ref reference data

* Updating develop with changes to the unit tests names. Renaming unit_test.yml to a more generic testing.yml name since it compiles AND/OR runs unit tests. Also make the job names more concise so its easier to see what's running in the action summary window on GitHub.

* fixed directory to copy truth data into -- copy command was copying the content of the directory, not including the directory itself

* Per #1907, added warning about switch from Ensemble-Stat to Gen-Ens-Prod (#2032)

Co-authored-by: Julie Prestopnik <[email protected]>

* 2028 Check null for header data

* Removed un-reachable code

* #2028 Check if the pointer (d) is null

* #2015 Changed warning to debug message

* #2028 Passing two dimensionl cur and dim array

* #2028 Set obs_data

* Feature 2003 briercl (#2034)

* do not run testing workflow if changes are isolated to the met/docs directory

* Per #2013, changed source and README.  ci-run-unit (#2039)

* Feature 1055 read rot latlon (#2041)

* CI: output summary of differences in GHA log to easily see results without having to download the log artifact

* #2027 Added a debug message

* #2027 ci-run-unit Changed wind thres

* #2027 ci-run-unit Increased the precision to debug message

* print end of script after error summary, ci-run-unit

* #2027 Increased the buffer and cheking the status of sprintf

* Feature 1998 standard sections (#2038)

* fixing section headers to be consistent with METplus #1998

* fixing section headers to be consistent with METplus #1998

* fixing section headers to be consistent with METplus #1998 missed one

* fixing section headers to be consistent with METplus #1998 try again

* fixing section headers to be consistent with METplus #1998 I had it right the first time

* fixing section headers to be consistent with METplus #1998

* fixing section headers to be consistent with METplus #1998 fixing mistake

* fixing section headers to be consistent with METplus #1998

* fixing section headers to be consistent with METplus #1998

* fixing section headers to be consistent with METplus #1998

* fixing section headers to be consistent with METplus #1998

* fixing section header underscore to dash #1998

* updating TOC vs ref 1998

* updating TOC vs ref 1998 completed

* trying to fix link #1998

* trying to fix link adding reference back in #1998

* updating TOC again underscore vs dash #1998

* updating TOC again underscore vs dash #1998

* updating TOC vs ref 1998 try

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998 take 2

* standardizing TOC sections #1998 take 3

* re-standardizing TOC sections #1998

* re-standardizing TOC sections #1998

* re-standardizing TOC sections #1998

* re-standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* updating questions into the TOC.  test #1998

* updating questions into the TOC. #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998 fixing typo

* standardizing TOC sections #1998 fixing typo

* standardizing TOC sections #1998 fixing typo

* standardizing TOC sections #1998 fixing typo

* standardizing TOC sections #1998 fixing typo

* standardizing TOC sections #1998 fixing typo

* cleaning up questions. removing section title from questions.

* adding a period #1989.

* adding the line breaks back in to match other formatting within MET #1989.

* Changed some "^^^" to "----"

* Changed "###" to "***"

Co-authored-by: jprestop <[email protected]>

* Update met_stats.cc

#2047 Removed the debug message

* Update met_stats.cc

Removing variable that was set but never used because SonarQube might complain about that, like Fortify does.

* Feature 2040 parse timing (#2048)

Co-authored-by: Julie Prestopnik <[email protected]>

* CI: Add logic to auto update input data (#2046)

* Bugfix 2045 develop hira (#2049)

Co-authored-by: jprestop <[email protected]>
Co-authored-by: Julie Prestopnik <[email protected]>
Co-authored-by: Seth Linden <[email protected]>
Co-authored-by: Seth Linden <[email protected]>
Co-authored-by: j-opatz <[email protected]>
Co-authored-by: hsoh-u <[email protected]>
Co-authored-by: Howard Soh <[email protected]>
Co-authored-by: George McCabe <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>
Co-authored-by: MET Tools Test Account <[email protected]>
Co-authored-by: mo-mglover <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>
Co-authored-by: Howard Soh <[email protected]>
Co-authored-by: davidalbo <[email protected]>
Co-authored-by: lisagoodrich <[email protected]>
@JohnHalleyGotway JohnHalleyGotway changed the title Add support for python embedding of point observations to MET tools that process them. Enhance Ensemble-Stat, Point-Stat, Plot-Point-Obs, and Point2Grid to support python embedding of point observations. Mar 2, 2022
@JohnHalleyGotway JohnHalleyGotway removed a link to a pull request Mar 11, 2022
14 tasks
JohnHalleyGotway added a commit that referenced this issue Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MET: Python Embedding priority: blocker Blocker requestor: NOAA/CPC NOAA Climate Prediction Center requestor: NOAA/OPC NOAA Ocean Prediction Center requestor: UK Met Office United Kingdom Met Office required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: new feature Make it do something new
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants