Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Stat-Analysis skill score index job which always writes a dump row output file. #1914

Closed
20 tasks done
JohnHalleyGotway opened this issue Sep 13, 2021 · 0 comments · Fixed by #1929
Closed
20 tasks done

Fix Stat-Analysis skill score index job which always writes a dump row output file. #1914

JohnHalleyGotway opened this issue Sep 13, 2021 · 0 comments · Fixed by #1929
Assignees
@JohnHalleyGotway
Labels
component: code cleanup Code cleanup and maintenance issue MET: Aggregation Tools reporting: DTC NCAR Base NCAR Base DTC Project requestor: METplus Team METplus Development Team required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: enhancement Improve something that it is currently doing
Milestone
MET 10.1.0

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Sep 13, 2021 •
edited
Loading

Describe the Enhancement

This is a small bug introduced during development for #1788. When running Stat-Analysis "-job ss_index" that is defined by a configuration file, the default filter job type is used to initialize that skill score index job. But the default filter job includes the "-dump_row filter_job.stat" option. And since that dump row setting is copied over to the -job ss_index, it is always used.

This issue is to cleanup that logic. The ss_index job should only write a dump row output file when the user actually specifies the "-dump_row" job command option.

Note that this creates the "filter_job.stat" file when the unit tests are run. Check to make sure that the fix prevents that from happenning.

Time Estimate

2 hours.

Sub-Issues

Consider breaking the enhancement down into sub-issues.
None.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: @JohnHalleyGotway
  • Select scientist(s) or no scientist required: none required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing component: code cleanup Code cleanup and maintenance issue priority: high requestor: METplus Team METplus Development Team required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project MET: Aggregation Tools labels Sep 13, 2021
@JohnHalleyGotway JohnHalleyGotway added this to the MET 10.1.0 milestone Sep 13, 2021
@JohnHalleyGotway JohnHalleyGotway self-assigned this Sep 13, 2021
@JohnHalleyGotway JohnHalleyGotway changed the title Fix a bug in the -ss_index job that it always writes a dump row output file named filter_job.stat. Fix Stat-Analysis bug in the skill score index job which always writes a dump row output file. Sep 13, 2021
JohnHalleyGotway added a commit that referenced this issue Sep 13, 2021
@JohnHalleyGotway
Per #1914, this fix is just in the STATAnalysis config files. The STA…
f3cbc60 
…TAnalysisConfig_default contains a job array with one entry, a filter job that writes a file named filter_job.stat. Since the skill score index config files did NOT contains a jobs array, that default setting was getting passed along. By adding an empty jobs array to these config files, the hope is the default job can be overridden.
JohnHalleyGotway added a commit that referenced this issue Sep 30, 2021
@JohnHalleyGotway
Per #1914, make the job array empty in the default STAT-Analysis conf…
386c8bc 
…ig file. Having an entry there that never actually gets exercised only causes confusion.
@JohnHalleyGotway JohnHalleyGotway linked a pull request Sep 30, 2021 that will close this issue
Feature 1914 dump_row #1929
Merged
12 tasks
JohnHalleyGotway added a commit that referenced this issue Sep 30, 2021
@JohnHalleyGotway
Per #1914, changing the top-level job control processing logic for ST…
4359d91 
…AT-Analysis. Previously, if a config file was specified, it processed only those jobs. Now, if -job is used on that command line, it'll run that job. If not, it'll get jobs from the -config file, and if none of that, then it'll error out telling the user to specify at least one job. This is a good change, in all the MET tools, we want the command line options to override any config file options.
@TaraJensen TaraJensen added the reporting: DTC NCAR Base NCAR Base DTC Project label Oct 1, 2021
@JohnHalleyGotway JohnHalleyGotway changed the title Fix Stat-Analysis bug in the skill score index job which always writes a dump row output file. Fix Stat-Analysis skill score index job which always writes a dump row output file. Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohnHalleyGotway JohnHalleyGotway

Labels
component: code cleanup Code cleanup and maintenance issue MET: Aggregation Tools reporting: DTC NCAR Base NCAR Base DTC Project requestor: METplus Team METplus Development Team required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: enhancement Improve something that it is currently doing
Projects
None yet
Milestone
MET 10.1.0
Development

Successfully merging a pull request may close this issue.

Feature 1914 dump_row dtcenter/MET
2 participants
@JohnHalleyGotway @TaraJensen