Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance compile_MET_all.sh to allow the user to specify the compiler and Python versions to load #2485

Closed
7 of 21 tasks
jprestop opened this issue Mar 7, 2023 · 0 comments · Fixed by #2548
Closed
7 of 21 tasks

Enhance compile_MET_all.sh to allow the user to specify the compiler and Python versions to load #2485

jprestop opened this issue Mar 7, 2023 · 0 comments · Fixed by #2548
Assignees
@jprestop
Labels
component: build process Build process issue priority: medium Medium Priority reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: METplus Team METplus Development Team type: task An actionable item of work
Milestone
MET 11.1.0

Comments

@jprestop
Copy link
Collaborator

jprestop commented Mar 7, 2023 •
edited
Loading

Describe the Task

This issue arose from a METplus Discussion Error installing with compile_MET_all.sh #2075.
An issue arose with the compilation script because the script assumes the module is going to be named $COMPILER_FAMILY/$COMPILER_VERSION. Any other naming convention will cause an error. It was suggested that since the script only loads the compiler and python modules it might be good to allow the user to override this default module and specify these.

Time Estimate

<1 day

Sub-Issues

Consider breaking the task down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

None

Funding Source

Split across 2700042, 2702691, 2792542

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@jprestop jprestop added type: task An actionable item of work alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Mar 7, 2023
@jprestop jprestop added this to the MET 11.1.0 milestone Mar 7, 2023
@JohnHalleyGotway JohnHalleyGotway added component: build process Build process issue requestor: METplus Team METplus Development Team priority: medium Medium Priority labels Mar 16, 2023
@jprestop jprestop removed alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels May 11, 2023
@jprestop jprestop changed the title Modify compilation to allow user to specify Compiler and Python version to load Modify compile_MET_all.sh to allow user to specify Compiler and Python version to load May 11, 2023
@jprestop jprestop added reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project labels May 17, 2023
jprestop added a commit that referenced this issue May 17, 2023
@jprestop
Per #2485, allow user to specify compiler name/version and python nam…
0da84f0 
…e/version modules to load
@jprestop jprestop removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label May 19, 2023
@jprestop jprestop linked a pull request May 19, 2023 that will close this issue
Feature 2540 2485 compilation #2548
Merged
15 tasks
jprestop added a commit that referenced this issue May 24, 2023
@jprestop
Feature 2540 2485 compilation (#2548)
1b4704a 
* Per 2540, added library name prefixes to log file names

* Per #2485, allow user to specify compiler name/version and python name/version modules to load

* Fix equality statement

* Added more documentation at the top
@JohnHalleyGotway JohnHalleyGotway changed the title Modify compile_MET_all.sh to allow user to specify Compiler and Python version to load Enhance compile_MET_all.sh to allow user to specify Compiler and Python version to load Jun 13, 2023
@JohnHalleyGotway JohnHalleyGotway changed the title Enhance compile_MET_all.sh to allow user to specify Compiler and Python version to load Enhance compile_MET_all.sh to allow the user to specify the compiler and Python versions to load Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jprestop jprestop

Labels
component: build process Build process issue priority: medium Medium Priority reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: METplus Team METplus Development Team type: task An actionable item of work
Projects
No open projects
MET-11.1.0 Development
Status: ✅ Done
Milestone
MET 11.1.0
Development

Successfully merging a pull request may close this issue.

Feature 2540 2485 compilation dtcenter/MET
2 participants
@jprestop @JohnHalleyGotway