Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance TC-RMW to reorder the dimensions of the NetCDF output to store the gridded dimensions last #2523

Closed
8 of 21 tasks
JohnHalleyGotway opened this issue Apr 26, 2023 · 0 comments · Fixed by #2524
Closed
8 of 21 tasks
Assignees
Labels
MET: Tropical Cyclone Tools priority: high High Priority requestor: METplus Team METplus Development Team type: enhancement Improve something that it is currently doing
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Apr 26, 2023

Describe the Enhancement

During development for MET #2168, it was noted that the NetCDF output generated by the TC-Diag tool should order the NetCDF output dimensions as time, lat, lon. The python diagnostics code expects the dimensions to be ordered in this way. I also see this convention in WRF files:

float UU(Time, num_metgrid_levels, south_north, west_east_stag) ;

And in SWPC NetCDF output files:

float TEC(time, latitude, longitude) ;

While the CF-convention does NOT force an order for the dimensions, the earlier COARDS convention does, as described in this section. And it is generally encouraged to considered to continue with this ordering for compatibility with existing tools, such as ncview.

This task is to reorder the dimensions of the NetCDF output from the tc_rmw tool to list the range and azimuth dimensions last. So change...
FROM: double TMP(range, azimuth, pressure, track_point) ;
TO: double TMP(track_point, pressure, range, azimuth) ;

Time Estimate

4 hours.

Sub-Issues

Consider breaking the enhancement down into sub-issues.
None needed

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

TC-Diag project 2770043

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Thanks @bikegeek for finding the code to generate TCRMW plots in METplotpy:
https://github.com/dtcenter/METplotpy/blob/develop/metplotpy/contributed/tc_rmw/plot_fields.py
Its reads in data via read_tcrmw in the tc_utils.py:
https://github.com/dtcenter/METplotpy/blob/develop/metplotpy/contributed/tc_rmw/tc_utils.py
These will need to be updated.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing requestor: METplus Team METplus Development Team MET: Tropical Cyclone Tools priority: high High Priority labels Apr 26, 2023
@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.1.0 milestone Apr 26, 2023
@JohnHalleyGotway JohnHalleyGotway changed the title Reorder the NetCDF dimensions of TC-RMW output to be time, level, lat, lon Reorder the NetCDF dimensions of TC-RMW output to store gridded dimensions last Apr 26, 2023
JohnHalleyGotway added a commit that referenced this issue Apr 26, 2023
…_rmw tool. The dimensions should have time first, vertical level second (if applicable), and then gridded dimensions (i.e. lat,lon) last.
@JohnHalleyGotway JohnHalleyGotway linked a pull request Apr 27, 2023 that will close this issue
15 tasks
JohnHalleyGotway added a commit that referenced this issue May 10, 2023
@JohnHalleyGotway JohnHalleyGotway changed the title Reorder the NetCDF dimensions of TC-RMW output to store gridded dimensions last Enhance TC-RMW to reorder the dimensions of the NetCDF output to store the gridded dimensions last Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MET: Tropical Cyclone Tools priority: high High Priority requestor: METplus Team METplus Development Team type: enhancement Improve something that it is currently doing
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants