Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Correct the usage statement for Point2Grid #2666

Closed
23 tasks
hsoh-u opened this issue Aug 23, 2023 · 0 comments · Fixed by #2700 or #2704
Closed
23 tasks

Bugfix: Correct the usage statement for Point2Grid #2666

hsoh-u opened this issue Aug 23, 2023 · 0 comments · Fixed by #2700 or #2704
Assignees
Labels
Milestone

Comments

@hsoh-u
Copy link
Collaborator

hsoh-u commented Aug 23, 2023

Replace italics below with details for this issue.

Describe the Problem

The input of point2grid is a MET point NetCDF, GOES data, and Point observation as NcCF, not a gridded data. The descrioption of "input_filename" should be updated.

bin/point2grid
DEBUG 1: Start point2grid by hsoh(9895) at 2023-08-23 15:48:52Z  cmd: bin/point2grid

*** Model Evaluation Tools (METV11.1.0) ***

Usage: point2grid
        input_filename
        to_grid
        output_filename
        ...
        where   "input_filename" is the gridded data file to be read (required).

User guide is correct.

The input_filename argument indicates the name of the input file to be processed. The input can be a MET NetCDF point observation file generated by other MET tools or a NetCDF AOD dataset from GOES16/17. Python embedding for point observations is also supported, as described in :numref:pyembed-point-obs-data.

Expected Behavior

Environment

Describe your runtime environment:
1. Machine: (e.g. HPC name, Linux Workstation, Mac Laptop)
2. OS: (e.g. RedHat Linux, MacOS)
3. Software version number(s)

To Reproduce

Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.
2792543 - NOAA Base

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as the next bugfix version
  • Select Coordinated METplus-X.Y Support project for support of the current coordinated release
  • Select MET-X.Y.Z Development project for development toward the next official release

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next bugfix version
    Select: Coordinated METplus-X.Y Support project for support of the current coordinated release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Close this issue.
@hsoh-u hsoh-u added type: bug Fix something that is not working alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Aug 23, 2023
@hsoh-u hsoh-u added this to the MET 12.0.0 milestone Aug 23, 2023
@hsoh-u hsoh-u changed the title Need to correct the usage message for point2grid Need to update the usage message for point2grid Aug 23, 2023
@hsoh-u hsoh-u added the priority: low Low Priority label Aug 23, 2023
@hsoh-u hsoh-u added reporting: DTC NCAR Base NCAR Base DTC Project MET: Regridding and removed alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Aug 25, 2023
@hsoh-u hsoh-u self-assigned this Aug 29, 2023
@hsoh-u hsoh-u linked a pull request Oct 3, 2023 that will close this issue
15 tasks
@hsoh-u hsoh-u linked a pull request Oct 4, 2023 that will close this issue
15 tasks
@hsoh-u hsoh-u removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Oct 5, 2023
@JohnHalleyGotway JohnHalleyGotway changed the title Need to update the usage message for point2grid Bugfix: Correct the usage statement for the Point2Grid tool Nov 17, 2023
@JohnHalleyGotway JohnHalleyGotway changed the title Bugfix: Correct the usage statement for the Point2Grid tool Bugfix: Correct the usage statement for Point2Grid Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🏁 Done
Development

Successfully merging a pull request may close this issue.

2 participants