Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance MET to compile and link against the Proj library #2669

Closed
8 of 21 tasks
JohnHalleyGotway opened this issue Aug 23, 2023 · 2 comments · Fixed by #2672, #2675, #2676 or #2710
Closed
8 of 21 tasks

Enhance MET to compile and link against the Proj library #2669

JohnHalleyGotway opened this issue Aug 23, 2023 · 2 comments · Fixed by #2672, #2675, #2676 or #2710
Assignees
@jprestop @JohnHalleyGotway
Labels
component: build process Build process issue priority: blocker Blocker requestor: METplus Team METplus Development Team type: new feature Make it do something new
Milestone
MET-12.0.0

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Aug 23, 2023 •
edited
Loading

Describe the New Feature

The vx_grid library in MET is being reimagined as a lightweight wrapper of the Proj library. This adds the Proj library as a required dependency for MET. This task is to install Proj on the development machine, seneca, and update MET's configuration script and Makefiles to link to them. Basically, any Makefile currently linking to the vx_grid library should now also link to Proj.

Remember to update the development environment setup scripts in MET/internal/scripts/environment accordingly.

Recommend coordinating with @jprestop to discuss the implications on the compile_MET_all.sh script and the various supported platforms.

Recommend updating the User's Guide during this process as well to clarify the dependencies.

Remember to update METbaseimage (https://github.com/dtcenter/METbaseimage/blob/main/Dockerfile) to install Proj as well.

Acceptance Testing

List input data types and sources.
Describe tests required for new functionality.

Time Estimate

4 days?

Sub-Issues

Consider breaking the new feature down into sub-issues.
None

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

7705991 MPAS Participation

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

New Feature Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Aug 23, 2023
@JohnHalleyGotway JohnHalleyGotway self-assigned this Aug 23, 2023
@JohnHalleyGotway JohnHalleyGotway added component: build process Build process issue priority: blocker Blocker requestor: METplus Team METplus Development Team type: new feature Make it do something new and removed alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle type: enhancement Improve something that it is currently doing labels Aug 23, 2023
@JohnHalleyGotway JohnHalleyGotway added this to the MET 12.0.0 milestone Aug 23, 2023
JohnHalleyGotway added a commit that referenced this issue Aug 23, 2023
@JohnHalleyGotway
Per #2669, add Proj settings to configure.ac and run bootstrap to upd…
af1f9e5 
…ate all the MET Makefile.in files.
JohnHalleyGotway added a commit that referenced this issue Aug 24, 2023
@JohnHalleyGotway
Per #2669, add info about to the installation and environment files. …
d0435ef 
…Also delete development.kiowa since that machine was decommissioned in June 2023.
JohnHalleyGotway added a commit that referenced this issue Aug 24, 2023
@JohnHalleyGotway
Per #2669, update Makefile.am and Makefile.in to link to -lproj when …
1defd4e 
…compiling the 50 applications that already link to -lvx_grid.
JohnHalleyGotway added a commit that referenced this issue Aug 24, 2023
@JohnHalleyGotway
Per #2669, update development environments and compilation script to …
c5ddf54 
…include the Proj library in the rpath settings.
@DanielAdriaansen DanielAdriaansen mentioned this issue Aug 24, 2023
Closed
20 tasks
JohnHalleyGotway added a commit that referenced this issue Aug 28, 2023
@JohnHalleyGotway
Per #2669, compile using the MET base image v2.1_beta4 to test whethe…
4a6c057 
…r or not MET successfully compiles in that METbaseimage
JohnHalleyGotway added a commit that referenced this issue Aug 28, 2023
@JohnHalleyGotway
Per #2669, update the METbaseimage tag from v2.0_debian10 to v2.1_bet…
b1b2687 
…a4 to test with the correct base image version
JohnHalleyGotway added a commit that referenced this issue Aug 29, 2023
@JohnHalleyGotway
Per #2669, I manually pushed the dtcenter/met-base:v2.1 image and am …
fff7c7c 
…updating this feature branch to use that image when compiling via GHA.
@JohnHalleyGotway JohnHalleyGotway linked a pull request Aug 29, 2023 that will close this issue
Feature #2669 proj #2672
Merged
15 tasks
JohnHalleyGotway added a commit that referenced this issue Aug 30, 2023
@JohnHalleyGotway
Per #2669, update the COMPILER setting to gnu_12.2.0 to be consistent…
7fc6018 
… with GCC version provided by Debian 12.
JohnHalleyGotway added a commit that referenced this issue Aug 31, 2023
@JohnHalleyGotway
Per #2669, update HDF configuration command to get it to compile for …
9b2b57d 
…Debian 12
JohnHalleyGotway added a commit that referenced this issue Aug 31, 2023
@JohnHalleyGotway
Per #2669, update Dockerfile to test compiling with Debian 12 METbase…
4353056 
…image.
JohnHalleyGotway added a commit that referenced this issue Sep 1, 2023
@JohnHalleyGotway
Per #2669, test the compilation with the v2.1_debian12 met-base image
beb9031
JohnHalleyGotway added a commit that referenced this issue Sep 1, 2023
@JohnHalleyGotway
Per #2669, updating Dockerfiles to test using base image v2.1, tagged…
657a2dc 
… at 2:20MST on 9/1.
JohnHalleyGotway added a commit that referenced this issue Sep 1, 2023
@JohnHalleyGotway
Per #2669, seems to need to link to -ltirpc whenever we link to the -…
e0af36f 
…lmfhdf library
JohnHalleyGotway added a commit that referenced this issue Sep 5, 2023
@JohnHalleyGotway
Per #2669, make logic, indentation, and spacing consistent throughout…
bbefa31 
… configure.ac
JohnHalleyGotway added a commit that referenced this issue Sep 5, 2023
@JohnHalleyGotway
Feature #2669 proj (#2672)
1ccc067
JohnHalleyGotway added a commit that referenced this issue Sep 6, 2023
@JohnHalleyGotway
Per #2669, update the met-base version number from v2.1 to v3.0 after…
e7b90e8 
… deciding that the METbaseimage version should be pushed to v3.0 because of the change to the operating system.
@JohnHalleyGotway JohnHalleyGotway linked a pull request Sep 6, 2023 that will close this issue
Feature #2669 proj METbaseimage v3.0 #2675
Merged
15 tasks
JohnHalleyGotway added a commit that referenced this issue Sep 6, 2023
@JohnHalleyGotway
Feature #2669 proj METbaseimage v3.0 (#2675)
ff667fa
@JohnHalleyGotway JohnHalleyGotway linked a pull request Sep 6, 2023 that will close this issue
Update develop-ref after #2672 and #2675 #2676
Merged
@JohnHalleyGotway JohnHalleyGotway mentioned this issue Sep 6, 2023
Merged
@jprestop jprestop reopened this Oct 6, 2023
@jprestop
Copy link
Collaborator

jprestop commented Oct 6, 2023

Reopening issue due adjustments that needed to be made for installation on Hera and Jet (and potentially other machines).

jprestop added a commit that referenced this issue Oct 6, 2023
@jprestop
Per #2669, make adjustments to get MET to compile on Jet and Hera
0f6e24a
jprestop added a commit that referenced this issue Oct 9, 2023
@jprestop
Per #2669, update SQLITE installation
c2fdb27
jprestop added a commit that referenced this issue Oct 9, 2023
@jprestop
Per #2669, adding in missing then keyword
47d3698
jprestop added a commit that referenced this issue Oct 9, 2023
@jprestop
Per #2669, fixing typo in value for SQLITE_LIB_DIR
c1a1ee8
jprestop added a commit that referenced this issue Oct 9, 2023
@jprestop
Per #2669, adding SQLITE_INCLUDE_DIR and SQLITE_LIB_DIR
1bfbe73
jprestop added a commit that referenced this issue Oct 9, 2023
@jprestop
Per #2669, updated installation files for SQLITE changes
46929c0
jprestop added a commit that referenced this issue Oct 10, 2023
@jprestop @JohnHalleyGotway
Feature 2669 proj comp (#2710)
bb90592 
* Per #2669, make adjustments to get MET to compile on Jet and Hera

* Removed beta1

* Removed beta1

* Update internal/scripts/installation/compile_MET_all.sh

Co-authored-by: John Halley Gotway <[email protected]>

* Per #2669, update SQLITE installation

* Per #2669, adding in missing then keyword

* Per #2669, fixing typo in value for SQLITE_LIB_DIR

* Per #2669, adding SQLITE_INCLUDE_DIR and SQLITE_LIB_DIR

* Per #2669, updated installation files for SQLITE changes

* Update internal/scripts/installation/compile_MET_all.sh

Co-authored-by: John Halley Gotway <[email protected]>

* Update internal/scripts/installation/compile_MET_all.sh

Co-authored-by: John Halley Gotway <[email protected]>

---------

Co-authored-by: John Halley Gotway <[email protected]>
@jprestop jprestop linked a pull request Oct 18, 2023 that will close this issue
Feature 2669 proj comp #2710
Merged
15 tasks
@jprestop
Copy link
Collaborator

Closing issue again as updates were merged with #2710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jprestop jprestop

@JohnHalleyGotway JohnHalleyGotway

Labels
component: build process Build process issue priority: blocker Blocker requestor: METplus Team METplus Development Team type: new feature Make it do something new
Projects
MET-12.0.0 Development
Status: 🏁 Done
Milestone
MET-12.0.0
2 participants
@jprestop @JohnHalleyGotway