Update develop-ref after 1562 #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* first stab at converting to sphinx * removing all slashes * adding new link to README.rst file * working on lists * Made formatting changes * Finished fcst section * fixing spelling, bolding and italics issues * updating web links * working on formatting * updating formatting * formatting * first attempt to clean up formatting completed. * adding README to the index file * fixing warning errors * Bringing README_TC into sphinx. Updating section headers * Adding README_TC * Made formatting updates to README.rst * corrected section under wavelet * small changes * removing met/data/config/README since it is now in met/docs/Users_Guide * Added some formatting for headers * fixing chapters & sections * Fixed warnings from building Co-authored-by: Julie.Prestopnik <[email protected]>
…entoried. This helps debugging issues with MET potentially not reading all input GRIB2 records on WCOSS.
PR #1550 broke the build. It removed the data/config/README file but left a reference to it in Makefile.am. I'm removing that reference directly in the develop branch to get the Docker build, nightly regression test, and nightly Fortify build working.
* first stab at converting to sphinx * removing all slashes * adding new link to README.rst file * working on lists * Made formatting changes * Finished fcst section * fixing spelling, bolding and italics issues * updating web links * working on formatting * updating formatting * formatting * first attempt to clean up formatting completed. * adding README to the index file * fixing warning errors * Bringing README_TC into sphinx. Updating section headers * Adding README_TC * Made formatting updates to README.rst * corrected section under wavelet * small changes * removing met/data/config/README since it is now in met/docs/Users_Guide * Added some formatting for headers * fixing chapters & sections * Fixed warnings from building * adding in code blocks * removing slashes * changes * Made changes to formatting * removing For example code blocks * major updates * fist pass at document conversion complete. * cleaning up questions about dashes * Made some formatting modifications * Removing README_TC because it is being replaced by README_TC.rst in met/docs/Users_Guide * Removing the reference to the README_TC file * Making title capitalization consistent with README * Added a space in timestring * changing to 'time string' with a space between the words. * adding a link to the new README_TC location in met/docs/Users_Guide * Modified references to README and README_TC Co-authored-by: Julie.Prestopnik <[email protected]>
* Per #1562, add the same grid_diag fix for the develop branch. * Per #1562, removing the poly = CONUS.poly mask from GridDiagConfig_TMP. That settting masked a problem in the handling of missing data. Exercising the mask.poly option is tested in another unit test. This will change the output and break the nightly build, but that's good since we'll do more thorough testing.
…to print out some additional log messages that may help in debugging the intermittent file list failure.
8 tasks
jprestop
reviewed
Nov 17, 2020
| @@ -255,24 +255,22 @@ Part of the strength of MET is the leveraging of capability across tools. There | |||
|
|
|||
| Many of the MET tools use a configuration file to set parameters. This prevents the command line from becoming too long and cumbersome and makes the output easier to duplicate. | |||
|
|
|||
| Settings common to multiple tools are described in the following sections while those specific to individual tools are explained in the sections for those tools. In addition, these configuration settings are described in the **share/met/config/README** file and the **share/met/config/README-TC** file for the MET-Tropical Cyclone tools. | |||
| Settings common to multiple tools are described in the following sections while those specific to individual tools are explained in the sections for those tools. In addition, these configuration settings are described in the *share/met/config/README* file and the *share/met/config/README-TC* file for the MET-Tropical Cyclone tools. | |||
There was a problem hiding this comment.
I just noticed these references to the config/README files. I'll plan to fix these up when I modify the test/config files and do it all in that one commit since they are related.
jprestop
reviewed
Nov 17, 2020
|
|
||
| .. _Data IO MET-TC Configuration File Options: | ||
|
|
||
| MET-TC Configuration File Options | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| The information listed below may also be found in the **data/config/README_TC** file. | ||
| The information listed below may also be found in the *data/config/README_TC* file. |
jprestop
approved these changes
Nov 17, 2020
JohnHalleyGotway
changed the title
JohnHalleyGotway
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix #1562 and pull request #1564 changed a configuration file in unit_grid_diag.xml. This resulted in an expected change in the nightly build output to this file:
test_output/grid_diag/grid_diag_temperature.nc
Merging develop into develop-ref to get past these expected differences.
Pull Request Testing
Describe testing already performed for these changes:
Reviewed updated output to confirm that it is as expected.
Recommend testing for the reviewer to perform, including the location of input datasets:
None needed.
Will this PR result in changes to the test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
As described above.
After merging, should the reviewer DELETE the feature branch from GitHub? [Yes]
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s), Project(s), and Milestone
Does not apply.