Bugfix 1618 main v91 pb2nc #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
georgemccabe
approved these changes
Jan 19, 2021
There was a problem hiding this comment.
I ran the test and confirmed that all 200 runs succeeded.
/d1/personal/hsoh/git/bugfix/bugfix_1618_pb2nc/MET/met/bin/pb2nc: Success: 200 Failure: 0 out of 200
I then ran it again using the version of pb2nc in /usr/local/met and verified that it did seg fault many times.
/usr/local/met/bin/pb2nc: Success: 91 Failure: 109 out of 200
I approve the changes.
JohnHalleyGotway
added a commit
that referenced
this pull request
Jan 28, 2021
* Add debug level 4 message to list out the number of GRIB2 records inventoried. This helps debugging issues with MET potentially not reading all input GRIB2 records on WCOSS. * Bugfix 1554 main_v9.1 ncdump (#1555) * Bugfix 1562 main_v9.1 grid_diag (#1563) * Per #1562, check for bad data values before adding data to the PDF's for grid_diag. * Per #1562, removing the poly = CONUS.poly mask from GridDiagConfig_TMP. That settting masked a problem in the handling of missing data. Exercising the mask.poly option is tested in another unit test. This will change the output and break the nightly build, but that's good since we'll do more thorough testing. * Per #1508, change the verbosity in unit_tc_gen.xml from -v 2 to -v 5 to print out some additional log messages that may help in debugging the intermittent file list failure. * Feature 1572 v9.1.1 (#1573) * Per #1572, delete the docs/version file as it is not needed here. * Per #1572, update the version number to 9.1.1. * Per #1572, list the met-9.1.1 release date as 20201119 for the docs. * Per #1572, add release notes for the met-9.1.1 verison. * Per #1572, add release notes for met-9.1.1 version. * Per #1572, let's try to release met-9.1.1 today 11/18. * Correct GitHub link. * Fix small typo in release notes. * Bugfix 1618 main v91 pb2nc (#1622) Co-authored-by: Howard Soh <[email protected]> * Update pull_request_template.md * Per #1638, apply the same 3 fixes to the main_v9.1 branch to be included in the next bugfix release for met-9.1. (#1640) Co-authored-by: hsoh-u <[email protected]> Co-authored-by: Howard Soh <[email protected]>
JohnHalleyGotway
added a commit
that referenced
this pull request
Mar 12, 2021
* Add debug level 4 message to list out the number of GRIB2 records inventoried. This helps debugging issues with MET potentially not reading all input GRIB2 records on WCOSS. * Bugfix 1554 main_v9.1 ncdump (#1555) * Bugfix 1562 main_v9.1 grid_diag (#1563) * Per #1562, check for bad data values before adding data to the PDF's for grid_diag. * Per #1562, removing the poly = CONUS.poly mask from GridDiagConfig_TMP. That settting masked a problem in the handling of missing data. Exercising the mask.poly option is tested in another unit test. This will change the output and break the nightly build, but that's good since we'll do more thorough testing. * Per #1508, change the verbosity in unit_tc_gen.xml from -v 2 to -v 5 to print out some additional log messages that may help in debugging the intermittent file list failure. * Feature 1572 v9.1.1 (#1573) * Per #1572, delete the docs/version file as it is not needed here. * Per #1572, update the version number to 9.1.1. * Per #1572, list the met-9.1.1 release date as 20201119 for the docs. * Per #1572, add release notes for the met-9.1.1 verison. * Per #1572, add release notes for met-9.1.1 version. * Per #1572, let's try to release met-9.1.1 today 11/18. * Correct GitHub link. * Fix small typo in release notes. * Bugfix 1618 main v91 pb2nc (#1622) Co-authored-by: Howard Soh <[email protected]> * Update pull_request_template.md * Per #1638, apply the same 3 fixes to the main_v9.1 branch to be included in the next bugfix release for met-9.1. (#1640) * Per #1646, one line fix for cut-and-paste error. (#1648) * Adding necessary files for ReadTheDocs (#1703) * Per #1706, update aggr_ecnt_lines() to also add an entry to the skip_ba array of booleans. This is used to keep track of whether or not the point should be excluded from the statistics and is used in the Ensemble-Stat. This same aggregation code in the vx_statistics library is used by Stat-Analysis. Since Stat-Analysis failed to populate that array, it led to an array parsing error in ECNTInfo::set() when trying to compute the sum of the weights. (#1707) * Per #1694, exactly the same set of bugfix changes but applied to main_v9.1 rather than the develop branch. (#1709) * Feature 1710 v9.1.2 (#1711) * Per #1710, update the release notes and version numbers for the 9.1.2 release. * Per #1710, add a release note about the move to read the docs. Co-authored-by: hsoh-u <[email protected]> Co-authored-by: Howard Soh <[email protected]> Co-authored-by: jprestop <[email protected]>
21 tasks
JohnHalleyGotway
added a commit
that referenced
this pull request
Mar 20, 2021
* Add debug level 4 message to list out the number of GRIB2 records inventoried. This helps debugging issues with MET potentially not reading all input GRIB2 records on WCOSS. * Bugfix 1554 main_v9.1 ncdump (#1555) * Bugfix 1562 main_v9.1 grid_diag (#1563) * Per #1562, check for bad data values before adding data to the PDF's for grid_diag. * Per #1562, removing the poly = CONUS.poly mask from GridDiagConfig_TMP. That settting masked a problem in the handling of missing data. Exercising the mask.poly option is tested in another unit test. This will change the output and break the nightly build, but that's good since we'll do more thorough testing. * Per #1508, change the verbosity in unit_tc_gen.xml from -v 2 to -v 5 to print out some additional log messages that may help in debugging the intermittent file list failure. * Feature 1572 v9.1.1 (#1573) * Per #1572, delete the docs/version file as it is not needed here. * Per #1572, update the version number to 9.1.1. * Per #1572, list the met-9.1.1 release date as 20201119 for the docs. * Per #1572, add release notes for the met-9.1.1 verison. * Per #1572, add release notes for met-9.1.1 version. * Per #1572, let's try to release met-9.1.1 today 11/18. * Correct GitHub link. * Fix small typo in release notes. * Bugfix 1618 main v91 pb2nc (#1622) Co-authored-by: Howard Soh <[email protected]> * Update pull_request_template.md * Per #1638, apply the same 3 fixes to the main_v9.1 branch to be included in the next bugfix release for met-9.1. (#1640) * Per #1646, one line fix for cut-and-paste error. (#1648) * Adding necessary files for ReadTheDocs (#1703) * Per #1706, update aggr_ecnt_lines() to also add an entry to the skip_ba array of booleans. This is used to keep track of whether or not the point should be excluded from the statistics and is used in the Ensemble-Stat. This same aggregation code in the vx_statistics library is used by Stat-Analysis. Since Stat-Analysis failed to populate that array, it led to an array parsing error in ECNTInfo::set() when trying to compute the sum of the weights. (#1707) * Per #1694, exactly the same set of bugfix changes but applied to main_v9.1 rather than the develop branch. (#1709) * Feature 1710 v9.1.2 (#1711) * Per #1710, update the release notes and version numbers for the 9.1.2 release. * Per #1710, add a release note about the move to read the docs. * #1715 Do not combined if there are no overlapping beteewn TQZ and UV records * #1715 Do not combined if there are no overlapping beteewn TQZ and UV records * #1715 Do not combined if there are no overlapping beteewn TQZ and UV records * #1715 Added blank line for Warning * #1715 Added a blank line for Error * Bugfix 1716 main_v9.1 perc_thresh (#1721) * Per #1716, committing the same bugfix to the main_v9.1 branch for inclusion in the 9.1.3 bugfix release. * Per #1716, change SFP50 example to SFP33.3 to show an example of using floating point percentile values. * Per #1723, update the verison number to 9.1.3. (#1730) * Update pull_request_template.md Co-authored-by: hsoh-u <[email protected]> Co-authored-by: Howard Soh <[email protected]> Co-authored-by: jprestop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Describe testing already performed for these changes:
Recommend testing for the reviewer to perform, including the location of input datasets:
Will this PR result in changes to the test suite? [No]
After merging, should the reviewer DELETE the feature branch from GitHub? [Yes]
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s), Project(s), and Milestone
How to test
at kiowa
It will run pb2nc 200 times.
The expected output is: