Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1471 python_grid #1704

Merged
merged 8 commits into from
Mar 10, 2021
Merged

Feature 1471 python_grid #1704

merged 8 commits into from
Mar 10, 2021

Commits on Mar 9, 2021

  1. Per #1471, defined a parse_grid_string() function in the vx_statistic…

    …s library and then updated vx_data2d_python to call that function. However, this creates a circular dependency because vx_data2d_python now depends on vx_statistics.
    JohnHalleyGotway committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    697f362 View commit details
    Browse the repository at this point in the history
  2. Per #1471, because of the change in dependencies, I had to modify man…

    …y, many Makefile.am files to link to the -lvx_statistics after -lvx_data2d_python. This is not great, but I didn't find a better solution.
    JohnHalleyGotway committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    a8f4b65 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    42233f6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    652a6a7 View commit details
    Browse the repository at this point in the history
  5. Per #1471, add 3 new unit tests to demonstrate setting the python gri…

    …d as a named grid, grid specification string, or a gridded data file.
    JohnHalleyGotway committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    d4c631c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    85f4291 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a14ea34 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2021

  1. Per #1471, lots of Makefile.am changes to get this code to compile on…

    … kiowa. Worringly, it compiled and linked fine on my Mac laptop but not on kiowa. Must be some large differences in the linker logic.
    John Halley Gotway committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    884d841 View commit details
    Browse the repository at this point in the history