Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update develop-ref after #1704 and #1708 #1712

Merged
merged 31 commits into from
Mar 11, 2021
Merged

Commits on Feb 26, 2021

  1. Configuration menu
    Copy the full SHA
    ab0f2c6 View commit details
    Browse the repository at this point in the history
  2. Feature 1429 tc_log second try (#1686)

    * Per #1429, enhance error message from DataLine::get_item().
    
    * Per #1429, I realize that the line number actually is readily available in the DataLine class... so include it in the error message.
    JohnHalleyGotway authored Feb 26, 2021
    Configuration menu
    Copy the full SHA
    b2754b4 View commit details
    Browse the repository at this point in the history
  3. Feature 1588 ps_log (#1687)

    * Per #1588, updated pair_data_point.h/.cc to add detailed Debug(4) log messages, as specified in the GitHub issue. Do still need to test each of these cases to confirm that the log messages look good.
    
    * Per #1588, switch very detailed interpolation details from debug level 4 to 5.
    
    * Per #1588, remove the Debug(4) log message about duplicate obs since it's been moved up to a higher level.
    
    * Per #1588, add/update detailed log messages when processing point observations for bad data, off the grid, bad topo, big topo diffs, bad fcst value, and duplicate obs.
    JohnHalleyGotway authored Feb 26, 2021
    Configuration menu
    Copy the full SHA
    a1aead4 View commit details
    Browse the repository at this point in the history
  4. #1454 Disabled plot_data_plane_CESM_SSMI_microwave and plot_data_plan…

    …e_CESM_sea_ice_nc becaues of not evenly spaced
    Howard Soh committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    2ba6cd9 View commit details
    Browse the repository at this point in the history
  5. #1454 Moved NC attribute name to nc_utils.h

    Howard Soh committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    fe5f318 View commit details
    Browse the repository at this point in the history
  6. #1454 Corrected sanity checking for lat/lon projection based on the p…

    …ercentage of the delta instead of fixed tolerance
    Howard Soh committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    c1463b2 View commit details
    Browse the repository at this point in the history
  7. #1454 Corrected sanity checking for lat/lon projection based on the p…

    …ercentage of the delta instead of fixed tolerance
    Howard Soh committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    ac4d7f9 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2021

  1. #1454 Corrected data.delta_lon

    Howard Soh committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    371dd2c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    24c2bd8 View commit details
    Browse the repository at this point in the history
  3. 454 Deleted instea dof commenting out

    Howard Soh committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    e224ce1 View commit details
    Browse the repository at this point in the history
  4. 454 Deleted instea dof commenting out

    Howard Soh committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    c8e9049 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #1688 from dtcenter/feature_1454_nccf_grid_definition

    Feature 1454 nccf grid definition
    hsoh-u authored Mar 1, 2021
    Configuration menu
    Copy the full SHA
    0f5366c View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2021

  1. Feature 1684 bss and 1685 single reference model (#1689)

    * Per #1684, move an instance of the ClimoCDFInfo class into PairBase. Also define derive_climo_vals() and derive_climo_prob() utility functions.
    
    * Add to VxPairDataPoint and VxPairDataEnsemble functions to set the ClimoCDFInfo class.
    
    * Per #1684, update ensemble_stat and point_stat to set the ClimoCDFInfo object based on the contents of the config file.
    
    * Per #1684, update the vx_statistics library and stat_analysis to make calls to the new derive_climo_vals() and derive_climo_prob() functions.
    
    * Per #1684, since cdf_info is a member of PairBase class, need to handle it in the PairDataPoint and PairDataEnsemble assignment and subsetting logic.
    
    * Per #1684, during development, I ran across and then updated this log message.
    
    * Per #1684, working on log messages and figured that the regridding climo data should be moved from Debug(1) to at least Debug(2).
    
    * Per #1684 and #1685, update the logic for the derive_climo_vals() utility function. If only a single climo bin is requested, just return the climo mean. Otherwise, sample the requested number of values.
    
    * Per #1684, just fixing the format of this log message.
    
    * Per #1684, add a STATLine::get_offset() member function.
    
    * Per #1684, update parse_orank_line() logic. Rather than calling NumArray::clear() call NumArray::erase() to preserve allocated memory. Also, instead of parsing ensemble member values by column name, parse them by offset number.
    
    * Per #1684, call EnsemblePairData::extend() when parsing ORANK data to allocate one block of memory instead of bunches of litte ones.
    
    * Per #1684 and #1685, add another call to Ensemble-Stat to test computing the CRPSCL_EMP from a single climo mean instead of using the full climo distribution.
    
    * Per #1684 and #1685, update ensemble-stat docs about computing CRPSS_EMP relative to a single reference model.
    
    * Per #1684, need to update Grid-Stat to store the climo cdf info in the PairDataPoint objects.
    
    * Per #1684, remove debug print statements.
    
    * Per #1684, need to set cdf_info when aggregating MPR lines in Stat-Analysis.
    
    * Per #1684 and #1685, update PairDataEnsemble::compute_pair_vals() to print a log message indicating the climo data being used as reference:
    
    For a climo distribution defined by mean and stdev:
    DEBUG 3: Computing ensemble statistics relative to a 9-member climatological ensemble.
    
    For a single deterministic reference:
    DEBUG 3: Computing ensemble statistics relative to the climatological mean.
    JohnHalleyGotway authored Mar 2, 2021
    Configuration menu
    Copy the full SHA
    996197c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    40b57af View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2021

  1. Configuration menu
    Copy the full SHA
    23dc482 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2021

  1. Per #1694, add VarInfo::magic_str_attr() to construct a field summary…

    … string from the name_attr() and level_attr() functions.
    JohnHalleyGotway committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    9c9c54c View commit details
    Browse the repository at this point in the history
  2. Per #1694, fixing 2 issues here. There was a bug in the computation o…

    …f the max value. Had a less-than sign that should have been greater-than. Also, switch from tracking data by it's magic_str() to simply using VAR_i and VAR_j strings. We *could* have just used the i, j integers directly, but constructing the ij joint histogram integer could have been tricky since we start numbering with 0 instead of 1. i=0, j=1 would result in 01 which is the same as integer of 1. If we do want to switch to integers, we just need to make them 1-based and add +1 all over the place.
    JohnHalleyGotway committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    a16bebc View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2021

  1. Configuration menu
    Copy the full SHA
    21e3eb7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0f84a5a View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1696 from dtcenter/bugfix_1694_grid_diag

    Bugfix 1694 grid_diag
    davidfillmore authored Mar 5, 2021
    Configuration menu
    Copy the full SHA
    5f551d2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9224844 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1b41a0a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8382b33 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    0303f1f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    99a6363 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2021

  1. Configuration menu
    Copy the full SHA
    592c937 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2021

  1. Per #1706, add bugfix to the develop branch. Also add a new job to un…

    …it_stat_analysis.xml to test out the aggregation of the ECNT line type. This will add new unit test output and cause the NB to fail. (#1708)
    JohnHalleyGotway authored Mar 10, 2021
    Configuration menu
    Copy the full SHA
    d80aafa View commit details
    Browse the repository at this point in the history
  2. Feature 1471 python_grid (#1704)

    * Per #1471, defined a parse_grid_string() function in the vx_statistics library and then updated vx_data2d_python to call that function. However, this creates a circular dependency because vx_data2d_python now depends on vx_statistics.
    
    * Per #1471, because of the change in dependencies, I had to modify many, many Makefile.am files to link to the -lvx_statistics after -lvx_data2d_python. This is not great, but I didn't find a better solution.
    
    * Per #1471, add a sanity check to make sure the grid and data dimensions actually match.
    
    * Per #1471, add 3 new unit tests to demonstrate setting the python grid as a named grid, grid specification string, or a gridded data file.
    
    * Per #1471, document python grid changes in appendix F.
    
    * Per #1471, just spacing.
    
    * Per #1471, lots of Makefile.am changes to get this code to compile on kiowa. Worringly, it compiled and linked fine on my Mac laptop but not on kiowa. Must be some large differences in the linker logic.
    
    Co-authored-by: John Halley Gotway <[email protected]>
    JohnHalleyGotway and John Halley Gotway authored Mar 10, 2021
    Configuration menu
    Copy the full SHA
    6ed8fc4 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2021

  1. Committing a fix for unit_python.xml directly to the develop branch. …

    …We referenced in a place where it's not defined.
    MET Tools Test Account committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    0f08b74 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2b5e37f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    48bb906 View commit details
    Browse the repository at this point in the history