Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 1755 nccf timelevel by string #1756

Merged
merged 2 commits into from
Apr 15, 2021

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented Apr 15, 2021

Pull Request Testing

  • Describe testing already performed for these changes:

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Added two line into PointStatConfig_wrapped

mpr_column     = [];
mpr_thresh     = [];

How to test

outdir=out_test
mkdir -p $outdir

export CLIMO_MEAN_FILE="";
export CLIMO_STDEV_FILE="";
export FCST_FIELD="{ name=\"t_2m\"; level=\"(20150715_000000,*,*)\"; cat_thresh=[ <=273,>273 ]; }";
export METPLUS_DESC="";
export METPLUS_MODEL="model = \"MPAS\";";
export METPLUS_OBTYPE="";
export METPLUS_REGRID_DICT="regrid = {to_grid = NONE;}";
export MODEL="MPAS";
export OBS_FIELD="{ name=\"TMP\"; level=\"Z2\"; cat_thresh=[ <=273,>273 ]; message_type = [\"ADPSFC\"]; }";
export OBS_WINDOW_BEGIN="-5400";
export OBS_WINDOW_END="5400";
export OBTYPE="";
export OUTPUT_PREFIX="";
export POINT_STAT_GRID="[\"FULL\"]";
export POINT_STAT_MESSAGE_TYPE="[\"ADPUPA\",\"ADPSFC\"]";
export POINT_STAT_POLY="[]";
export POINT_STAT_STATION_ID="[]";
export REGRID_TO_GRID="NONE";
export VERIF_MASK="";

/d1/personal/hsoh/git/bugfix/bugfix_1755_nccf_timelevel_by_string/MET/bin/point_stat \
    -v 5 \
    /d1/projects/MET/MET_Help/zhuming_data_20210414/mpas_wrf_cf_2015071500.nc \
    /d1/projects/MET/MET_Help/zhuming_data_20210414/pbs.2015071506.nc \
    /d1/personal/hsoh/git/bugfix/bugfix_1755_nccf_timelevel_by_string/MET/met/src/tools/core/point_stat/PointStatConfig_wrapped \
    -outdir $outdir
  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s), Project(s), and Milestone
  • After submitting the PR, select Linked Issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@hsoh-u hsoh-u added this to the MET 10.0.0 milestone Apr 15, 2021
@hsoh-u hsoh-u linked an issue Apr 15, 2021 that may be closed by this pull request
21 tasks
Copy link
Collaborator

@georgemccabe georgemccabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the example and confirmed that the correct time is now used. There was a small typo in the path to point_stat (missing met directory)

/d1/personal/hsoh/git/bugfix/bugfix_1755_nccf_timelevel_by_string/MET/met/bin/point_stat

I approve of these changes.

@hsoh-u hsoh-u merged commit 3c170e9 into develop Apr 15, 2021
@hsoh-u hsoh-u deleted the bugfix_1755_nccf_timelevel_by_string branch April 30, 2021 19:52
@hsoh-u hsoh-u restored the bugfix_1755_nccf_timelevel_by_string branch April 30, 2021 19:53
@hsoh-u hsoh-u deleted the bugfix_1755_nccf_timelevel_by_string branch April 30, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to get the time level by time string at MET NCCF input
3 participants