Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1833 main v10.0 discussions #1850

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

jprestop
Copy link
Collaborator

@jprestop jprestop commented Jul 8, 2021

Pull Request Testing

  • Describe testing already performed for these changes:

Reviewed the changes on the following pages to ensure the references from met_help were changed to Discussions and that the formatting looked correct:
https://met.readthedocs.io/en/feature_1833_main_v10.0_discussions/Users_Guide/index.html
https://met.readthedocs.io/en/feature_1833_main_v10.0_discussions/Users_Guide/tc-pairs.html
https://met.readthedocs.io/en/feature_1833_main_v10.0_discussions/Users_Guide/appendixA.html
https://met.readthedocs.io/en/feature_1833_main_v10.0_discussions/Users_Guide/overview.html

Additionally, I removed references to met_help in the following files:
met/data/wrappers/read_tmp_ascii.py
met/configure.ac

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Review the changes on the following pages to ensure the references from met_help were changed to Discussions and that the formatting looks correct:
https://met.readthedocs.io/en/feature_1833_main_v10.0_discussions/Users_Guide/index.html
https://met.readthedocs.io/en/feature_1833_main_v10.0_discussions/Users_Guide/tc-pairs.html
https://met.readthedocs.io/en/feature_1833_main_v10.0_discussions/Users_Guide/appendixA.html
https://met.readthedocs.io/en/feature_1833_main_v10.0_discussions/Users_Guide/overview.html

Please review the changes in the following files as well:
met/data/wrappers/read_tmp_ascii.py
met/configure.ac

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [Yes]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [07/13/21].

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop added this to the met-10.0.1 (bugfix) milestone Jul 8, 2021
@jprestop jprestop linked an issue Jul 8, 2021 that may be closed by this pull request
21 tasks
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look fine to me. I approve.

@jprestop jprestop merged commit 9831b9c into main_v10.0 Jul 8, 2021
@jprestop jprestop deleted the feature_1833_main_v10.0_discussions branch July 8, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation to reference GitHub Discussions instead of MET Help
2 participants