Update develop-ref after #1863 #1866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commented out items and added text to description
… if latitude moves north to south
…to_laton Bugfix 1817 point2grid latlon to laton
…arsing Bugfix 1508 tc_gen file list parsing
…_double_type_lat_lon Bugfix 1838 point2grid supports the double type lat/lon
…called API handles 2D or 3D)
* For issue #1746 modified code to allow users to pass in an empty list (or NA) for forecast and observation thresholds in order to skip applying the threhsolds, but it will still compute stats with the raw fields. SL * For issue #1746, added new unit test that uses a config file that has empty lists for the forecast and observation thresholds. SL * For issue #1746 Added some content related to allowing users to set forecast and observation cat thresholds to an empty list in order to skip the binary masking (and consider all grid-points for stats). SL * Per #1746, cleaning up for consistent indentation. * Per #1746, cleaning up for consistent indentation. * Per #1746, add a revision history note, update the plotting range in the postscript output to be [-n,n] where n is the maximum value of the maximum absolute difference and 1.0, and also fix a bug. When the NA threshold comes AFTER a real threshold, the resulting data and difference values were not being updated. * Per #1746, change the Wavelet-Stat config file values in the the wvlt_plot dictionary by setting plot_min = plot_max = 0.0. That enables the default logic of the tool to take effect. Choose the plotting range of the wavelet plots as [-n,n], where n is the maximum of 1.0 and the maximum absolute difference. * Per #1746, used apply_fcst_thresh where it should have been apply_obs_thresh. * Per issue #1746, modified some content related to users being able to skip applying the categorical threhsolds by putting an empty list or NA in the configuration file. SL * Per issue #1746 Added some warnings if the forecast threshold is set to NA but the observation threshold is not NA (a numeric threshold) and vice versa. SL * Per #1746, fix a couple of typos and tweak wording in the wavelet-stat chapter. * Per #1746, loop over each pair of fcst/obs thresholds to check for inconsistent use of the NA threshold type. * Per #1746, a bit of code cleanup replacing calls to n_elements() with n() to make the code more concise. * Per #1746, need to reinitialize apply_fcst_thresh and apply_obs_thresh to true inside the loop since the NA threshold can appear anywhere in the list of thresholds. Co-authored-by: Seth Linden <[email protected]> Co-authored-by: John Halley Gotway <[email protected]>
Feature 1852 netcdf api for exceeding the start and the count
…able does not have dimension (#1860) Co-authored-by: Howard Soh <[email protected]>
* Enable PDF creation
* Modify inputenc, fontenc latex_elements
* Fix typo in conf.py
* Replace unicode with ascii
* Replace unicode exponent with math mode
* Change eqnarray to align
* Replace gif images with png for PDF
* Fix png file names
* Escape underscore in variable name in math mode
* Escape underscore in variable name in math mode
* Remove underscores from variables in math mode
* Replace bar with overline in some equations
* Test derefencing underscores in tables
* Test math changes in grid stat
* Test math formatting
* Test math formatting
* Add sphinx.ext.pngmath to conf.py
* Fix typo in conf.py
* Add sphinx.ext.mathjax to conf.py
* Add sphinx.ext.imgmath to conf.py
* Fix typo in conf.py
* Change math formatting in Appendix C
* Temporarily disable equations with errors in Appendix C
* Remove sphinx.ext.imgmath in conf.py
* Modify math formatting in Appendix C
* Modify math formatting in Appendix C
* Modify math formatting in Appendix C
* Add sphinx.ext.imgmath to conf.py
* Modify math formatting in Appendix C
* Temporarily disable equations with errors in Appendix C
* Remove sphinx.ext.imgmath in conf.py
* Modify math formatting in Appendix C
* Modify math formatting in Appendix C
* Temporarily disable equations with errors
* Modify math formatting in Appendix C
* Add usepackage{amssymb} to conf.py
* Modify math formatting in Appendix C
* Modify math formatting in Appendix C
* Modify math formatting in Appendix C
* Modify math formatting in Appendix C
* Modify math formatting in Appendix C
* Modify math formatting in Appendix C
* Modify math formatting in Appendix C
* Modify math formatting in Appendix C
* Modify math formatting in Appendix C
* Modify math formatting in Appendix C
* Modify math formatting in Appendix C
* Modify math formatting in Appendix C
* Modify math formatting in Appendix C
* Modify math formatting in Appendix C
* Modify math formatting in Appendix C
* Modify math formatting in Appendix C
* Modify math formatting in Appendix C
* Fix warnings in wavelet-stat.rst
* Omit Indices and tables in PDF version of User Guide
* Modify math formatting in Appendix G
* Modify math formatting in Appendix E
* Modify math formatting in Appendix G
* Modify math formatting in Appendix G
* Modify math formatting in Appendix G
* Modify math formatting in Appendix G
* Modify math formatting in Appendix G
* Modify math formatting in Appendix G
* Modify math formatting in Appendix G
* Modify math formatting in Appendix G
* Modify math formatting in Appendix G
* Change release date in conf.py
Co-authored-by: John Halley Gotway <[email protected]>
* Per #1853, adding RPS docs from Eric. * Per #1853, work in progress getting the formatting correct. * Per #1853, work in progress getting the formatting correct. * Per #1853, work in progress getting the formatting correct. * Per #1853, work in progress getting the formatting correct. * Per #1853, adding a manual page break after the ROC image to get it to stay in the right spot. * Per #1853, backing out last change which didn't make the ROC image stay in the right spot.
* Added scatter index variables: SI, SI_BCL, SI_BCU to cnt columns. SL * Per issue #1843 Added Scatter Index variables (SI, SI_BCL, SI_BCU) to the CNT stat type. SL * Added Scatter Index (SI, SI_BCL, SI_BCU) to cnt stat type header. SL * Per issue #1843, added Scatter Index variables to write_cnt_cols(). SL * Per issue #1843 added Scatter Index (si) to CNTinfo class. SL * Per issue #1843 added Scatter Index (SI, si) to CNTInfo::get_stat(). SL * Per issue #1843 added Scatter Index (SI, si) calculation to both versions of compute_cntinfo(). SL * Per issue #1843, forgot semi-colon after SI calculation, fixed. SL * Added Scatter Index (si) to some of the clear() and allocate() functions. SL * Per issue #1843, added Scatter Index (si) to compute_cnt_mean(). SL * Per issue #1843, added Scatter Index (si) to bootstrap interval calculation and to the CNT write function. SL * Per issue #1843 added Scatter Index (SI, SI_BCL, SI_BCU) to store_stat_cnt(). SL * Per issue #1843, in get_stat() moved Scatterd Index (SI) line to be below RMSE for consitency. SL * Added Scatter Index (SI) to the CNT output format table. SL * Added Scatter Index (SI) to CNT statistics definitions. SL * Update appendixC.rst * Update stat_columns.cc * Update compute_ci.cc * Update met_stats.cc * Per #1843, update write_cntinfo() function. Since we're READING the SI value immediately after the RMSE value when computing CI's, we also need to write SI immediately after RMSE. Otherwise, we'll be computing CI's using the wrong statistics replicates. * Per #1843, check for divide by zero when computing SI... this could happen if comparing the same input file to itself with Grid-Stat. * Per #1843, correct definition of SI from RMSE/ME to RMSE/OBAR. * Per #1843, updated the SI definition to divide by OBAR instead of ME, but forgot to update the divide-by-zero check. Co-authored-by: Seth Linden <[email protected]> Co-authored-by: johnhg <[email protected]>
21 tasks
JohnHalleyGotway
added a commit
that referenced
this pull request
Aug 20, 2021
…of type long long (<long long>) to avoid integer overflow in the grid_diag tool. Also, update grid_diag to write int64 NetCDF variables instead of int.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Pull Request #1863 for Issue #1843 adds new columns to the existing CNT line type. This causes the nightly build to flag those differences. Updating develop-ref to get past these changes.
Describe testing already performed for these changes:
Inspected NB output on kiowa in /d1/projects/MET/MET_regression/develop/NB20210801 and confirmed that all diffs are within the CNT line type. Spot checked a couple of them.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
None
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
Update reference version, as expected.
Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes