Bugfix 1936 develop madis2nc #1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… required variables for MESONET
22 tasks
Closed
12 tasks
JohnHalleyGotway
requested changes
Nov 30, 2021
There was a problem hiding this comment.
Please include the updates to unit_madis2nc.xml in this PR as well:
https://github.com/dtcenter/MET/pull/1963/files#diff-573ecd547d41d4d76bdc54fc39f46db5d1b32059163608a5bb89751b66e6ef6a
You've added a new madis unit test input file, and I'd like to include the testing of that in the develop branch.
JohnHalleyGotway
changed the title
JohnHalleyGotway
approved these changes
Dec 2, 2021
There was a problem hiding this comment.
I approve of these changes.
Thanks for adding the unit test Howard. I tested in kiowa:/d1/projects/MET/MET_pull_requests/met-10.1.0/met-10.1.0_beta5/bugfix_1936 and manually ran the updated version of unit_madis2nc.xml to confirm that it works... and it does.
14 tasks
JohnHalleyGotway
added a commit
that referenced
this pull request
Dec 2, 2021
Co-authored-by: Julie Prestopnik <[email protected]> Co-authored-by: johnhg <[email protected]> Co-authored-by: Seth Linden <[email protected]> Co-authored-by: John Halley Gotway <[email protected]> Co-authored-by: j-opatz <[email protected]> Co-authored-by: Howard Soh <[email protected]> Co-authored-by: jprestop <[email protected]> Co-authored-by: Seth Linden <[email protected]> Co-authored-by: hsoh-u <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Differences
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Describe testing already performed for these changes:
Tested with 2017 & 2021 mesonet data
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
export MET_BASE=/d1/personal/hsoh/git/features/feature_1936_main_v10_madis_nc/MET/met/share/met
/d1/personal/hsoh/git/features/feature_1936_main_v10_madis_nc/MET/met/bin/madis2nc /d1/projects/MET/MET_test_data/unit_test/obs_data/madis/mesonet/mesonet_20170101_0000.nc out_mesonet_20170101_0000.nc -type mesonet
/d1/personal/hsoh/git/features/feature_1936_main_v10_madis_nc/MET/met/bin/madis2nc /d1/personal/hsoh/data/MET-1936/20210101_0000 out_mesonet_20210101_0000.nc -type mesonet
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
Adds a new output file created by unit_madis2nc.xml that will cause the NB to fail.
Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes