Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1985 v10.0.1 #1986

Merged
merged 3 commits into from
Dec 1, 2021
Merged

Feature 1985 v10.0.1 #1986

merged 3 commits into from
Dec 1, 2021

Conversation

JohnHalleyGotway
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway commented Dec 1, 2021

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    None really. This just updates V10.0.0 to V10.0.1 and adds release notes.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    No testing needed.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
    Please review the updated release notes.

  • Do these changes include sufficient testing updates? [Yes]
    No testing changes needed.

  • Will this PR result in changes to the test suite? [Yes]

    If yes, describe the new output and/or changes to the existing output:

    Switching from V10.0.0 to V10.0.1 in the MET output files will cause the NB diffs to run very slowly. And it'll cause the MTD diffs to fail. When it does, manually inspect the diffs and update main_v10.0-ref to get past the diffs.

  • Please complete this pull request review by [12/1/2021].

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@JohnHalleyGotway JohnHalleyGotway added this to the met-10.0.1 (bugfix) milestone Dec 1, 2021
@JohnHalleyGotway JohnHalleyGotway linked an issue Dec 1, 2021 that may be closed by this pull request
20 tasks
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good. I double checked the links in the release notes section, and they were all correct. I approve this PR.

@JohnHalleyGotway JohnHalleyGotway merged commit 5e1f551 into main_v10.0 Dec 1, 2021
@JohnHalleyGotway JohnHalleyGotway deleted the feature_1985_v10.0.1 branch December 1, 2021 20:07
JohnHalleyGotway added a commit that referenced this pull request Dec 2, 2021
Co-authored-by: Julie Prestopnik <[email protected]>
Co-authored-by: Howard Soh <[email protected]>
Co-authored-by: bikegeek <[email protected]>
Co-authored-by: jprestop <[email protected]>
Co-authored-by: bikegeek <[email protected]>
Co-authored-by: George McCabe <[email protected]>
Co-authored-by: hsoh-u <[email protected]>
@JohnHalleyGotway JohnHalleyGotway mentioned this pull request Dec 8, 2021
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the MET v10.0.1 release
2 participants