Feature 1824 pb2nc MLCAPE2

[hsoh-u]

Expected Differences

Fixed the difference at CAPE after activating MLCAPE

• Do these changes introduce new tools, command line arguments, or configuration file options? [No]
  
  If yes, please describe:
  

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
  
  If yes, please describe:
  

Pull Request Testing

• Describe testing already performed for these changes:
  

Run unit test and compare the PBL and CAPE values

Rscript /d1/personal/hsoh/git/features/feature_1824_pb2nc_MLCAPE2/MET/met/scripts/Rscripts/pntnc2ascii.R /d1/projects/MET/MET_regression/develop/NB20220218/MET-develop-ref/test_output/pb2nc_indy/nam.20210311.t00z.prepbufr.tm00.pbl.nc | grep -v "MLCAPE" > ref_cape.txt

Rscript /d1/personal/hsoh/git/features/feature_1824_pb2nc_MLCAPE2/MET/met/scripts/Rscripts/pntnc2ascii.R /d1/personal/hsoh/MET/test_output/feature_1824_pb2nc_MLCAPE2/pb2nc_indy/nam.20210311.t00z.prepbufr.tm00.pbl.nc | grep -v "MLCAPE" > new_cape.txt

vimdiff ref_cape.txt new_cape.txt

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

• Do these changes include sufficient testing updates? [No]

• Will this PR result in changes to the test suite? [No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Please complete this pull request review by [Fill in date].
  

Pull Request Checklist

See the METplus Workflow for details.

• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select Linked issues with the original issue number.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[JohnHalleyGotway]

@hsoh-u thanks for working on this. I carefully diffed the nam and ndas files that were flagged by the regression test. Please see below before merging this PR.

1. There are no unexpected diffs in the "ndas" output files - only the addition of MLCAP obs.
2. Comparing the "nam" output files, 4 HBPL observations with a value 0 are now missing.

Rscript pntnc2ascii.R nam.20210311.t00z.prepbufr.tm00.pbl_TRUTH.nc | sed -r 's/ $/00 /g' > nam.20210311.t00z.prepbufr.tm00.pbl_TRUTH.txtRscript pntnc2ascii.R nam.20210311.t00z.prepbufr.tm00.pbl_OUTPUT.nc | egrep -v MLCAPE > nam.20210311.t00z.prepbufr.tm00.pbl_OUTPUT.txt
diff nam.20210311.t00z.prepbufr.tm00.pbl_TRUTH.txt nam.20210311.t00z.prepbufr.tm00.pbl_OUTPUT.txt

There are 4 HBPL observations from TRUTH that no longer appear in OUTPUT:

74,75d73
< ADPUPA 30119A 20210310_232900 36.10 -128.10 9300 HPBL NA 0 2    0.000000 
< ADPUPA 30120A 20210310_235300 35.80 -125.10 9450 HPBL NA 0 2    0.000000 
165,166d162
< ADPUPA 30122A 20210311_001700 37.90 -125.50 9450 HPBL NA 0 2    0.000000 
< ADPUPA 30125A 20210311_003300 37.30 -123.80 9450 HPBL NA 0 2    0.000000 

I compared the many other HPBL obs and these values of 0 are the only ones missing. So I assume that that was an intentional change included in this PR.

If that change was intentional, please merge this PR. If not and those HPBL obs = 0 should remain, please take a closer look.

[hsoh-u]

This was reported as the difference at Docker build. It turned out this happening when the merged PTQ and UV record is only: The computed PBL value is 0 at one system and filtered out (negative or greater than MAX) at other system.

This is a comment at PR #2057

- PBL is not computed if the merged PTQ & UV record is just 1 which was a difference between kiowa and seneca
  - no change at seneca
  - 4 less PBL data at nam.20210311.t00z.prepbufr.tm00.pbl.nc at kiowa & Docker


hsoh@kiowa:$  Rscript /d1/personal/hsoh/git/pull_request/MET_feature_1824_pb2nc_MLCAPE/met/scripts/Rscripts/pntnc2ascii.R /d1/projects/MET/MET_regression/develop/NB20220218/MET-develop/test_output//pb2nc_indy/nam.20210311.t00z.prepbufr.tm00.pbl.nc | grep PBL | wc -l
     102
hsoh@kiowa:$  Rscript /d1/personal/hsoh/git/pull_request/MET_feature_1824_pb2nc_MLCAPE/met/scripts/Rscripts/pntnc2ascii.R unit_test_output/pb2nc_indy/nam.20210311.t00z.prepbufr.tm00.pbl.nc | grep PBL | wc -l
     98
hsoh@seneca:$ Rscript met/scripts/Rscripts/pntnc2ascii.R  /d1/personal/hsoh/MET/test_output/feature_1824_pb2nc_MLCAPE/pb2nc_indy/nam.20210311.t00z.prepbufr.tm00.pbl.nc | grep PBL  | wc -l
     98
hsoh@seneca:$  Rscript met/scripts/Rscripts/pntnc2ascii.R  /d1/personal/hsoh/MET/test_output/feature_1824_pb2nc_MLCAPE/pb2nc_indy/nam.20210311.t00z.prepbufr.tm00.pbl.nc | grep MLCAPE  | wc -l
    147

[hsoh-u]

And one more data at ndas.20120409.t12z.prepbufr.tm00.var_all.nc (one MLCAPE value is added to the unit test of all variable)_.