Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #2354 v11.0.0-beta5 #2355

Merged
merged 2 commits into from
Nov 20, 2022
Merged

Conversation

JohnHalleyGotway
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway commented Nov 20, 2022

Note that these are changes to the release notes and also updates to the unit test diff logic to handle the newly modified TCMPR lines and newly added TCDIAG lines.

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

After a flurry of PR's in recent days, I need to carefully check all the diffs vs develop-ref and then update develop-ref to get past them.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    None. I will review the MET-11.0.0-beta5 release notes myself:
    https://met--2355.org.readthedocs.build/en/2355/Users_Guide/release-notes.html#met-version-11-0-0-beta5-release-notes-20221120

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
    Just the release notes.

  • Do these changes include sufficient testing updates? [No]
    None needed.

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [10/30/2022].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.0.0 milestone Nov 20, 2022
@JohnHalleyGotway JohnHalleyGotway merged commit 2bc783e into develop Nov 20, 2022
@JohnHalleyGotway JohnHalleyGotway deleted the feature_2354_v11.0.0-beta5 branch November 20, 2022 16:42
@JohnHalleyGotway JohnHalleyGotway linked an issue Nov 20, 2022 that may be closed by this pull request
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Create the MET-11.0.0-beta5 release
1 participant