Feature #2362 message_type_group_map

[JohnHalleyGotway]

Expected Differences

• Do these changes introduce new tools, command line arguments, or configuration file options? [No]
  
  If yes, please describe:
  

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
  
  If yes, please describe:
  

Pull Request Testing

• Describe testing already performed for these changes:
  

• Used the data in make test to test out this logic. When message_type_group_map in data/config/PointStatConfig is empty, make test now runs without error. Previously it errored out about SURFACE/LANDSF/WATERSF being missing. I ran this iteratively to trigger each of these errors separately. And then I reran iteratively to confirm that these errors are no longer present.

• Also, set topo_mask.flag = true and land_mask.flag = true and confirmed that that triggers the warning messages, as expected.

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

• @jprestop, review minor code change and confirm that all GHA runs pass without producing any diffs.

• @robdarvell, review the updated land_mask and topo_mask documentation to confirm that it clearly defines the message_type_group_map handling.

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

• Do these changes include sufficient testing updates? [No]
  None needed.

• Will this PR result in changes to the test suite? [No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Please complete this pull request review by [Mon 12/5/22].
  

Pull Request Checklist

See the METplus Workflow for details.

• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select Development with the original issue number.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[jprestop]

I reviewed the minor code changes and confirmed that all GHA runs pass without producing any diffs. This PR looks good to me!

[JohnHalleyGotway]

Thanks for the review @jprestop. @robdarvell I'm going to proceed with merging this PR based on Julie's review. My intention by adding you as a reviewer was to make you aware of this fix. So you'll only need to define SURFACE, LANDSF, and WATERSF in the future if you actually turn on the land_mask and topo_mask options.

Since you know that now, I'd say mission accomplished!

Thanks!