Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature #2473 v11.1.0-beta1 #2479

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Feature #2473 v11.1.0-beta1 #2479

merged 1 commit into from
Feb 28, 2023

Conversation

JohnHalleyGotway
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway commented Feb 28, 2023 •
edited
Loading

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    • Updated doc version to 11.1.0-beta1.
    • Rotated user's guide authorship for the next release.
    • Added beta1 release notes and upgrade instructions.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [No]

None needed.

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Tues 2/28/23].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.1.0 milestone Feb 28, 2023
@JohnHalleyGotway JohnHalleyGotway linked an issue Feb 28, 2023 that may be closed by this pull request
Create the MET-11.1.0-beta1 release #2473
Closed
20 tasks
jprestop
jprestop approved these changes Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the documentation and approve this pull request.

@jprestop jprestop removed the request for review from j-opatz February 28, 2023 21:57
@JohnHalleyGotway JohnHalleyGotway merged commit 70b2e6e into develop Feb 28, 2023
@JohnHalleyGotway JohnHalleyGotway deleted the feature_2473_v11.1.0-beta1 branch February 28, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jprestop jprestop jprestop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
MET-11.1.0 Development
Status: ✅ Done
Milestone
MET 11.1.0
Development

Successfully merging this pull request may close these issues.

Create the MET-11.1.0-beta1 release
2 participants
@JohnHalleyGotway @jprestop