Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #2421 Python 3.10.4 - update Dockerfiles #2480

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented Mar 1, 2023

Set default value of MET_BASE_TAG to the latest base image tag so DockerHub builds for tagged releases will succeed

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Do one of the following:

  • Re-tag MET 11.1.0-beta1 release and ensure DockerHub build succeeds
  • Create a dummy release to test that the build on DockerHub runs properly, then delete the tag/release
  • Follow up to ensure the next beta release (11.1.0-beta2) builds successfully on DockerHub with these changes
  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by 3/6/2023.

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…kerHub builds for tagged releases will succeed
@georgemccabe georgemccabe added this to the MET 11.1.0 milestone Mar 1, 2023
@georgemccabe georgemccabe linked an issue Mar 1, 2023 that may be closed by this pull request
22 tasks
@georgemccabe georgemccabe mentioned this pull request Mar 1, 2023
22 tasks
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve. Thanks for catching this. I'll plan to retag the release after this is merged and confirm that DockerHub is happy again.

@JohnHalleyGotway JohnHalleyGotway merged commit 9123ac0 into develop Mar 1, 2023
@JohnHalleyGotway JohnHalleyGotway deleted the feature_2421_py310_dockerfiles branch March 1, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Upgrade to using Python 3.10.4
2 participants