Per #2542 develop gheidke

[JohnHalleyGotway]

Expected Differences

This PR updates the error checking logic for the ContingencyTable class gheidke(), gheidke_ec(), gkuiper(), and gerrity() functions. Rather than erroring out for empty contingency tables, just return bad data.

• Do these changes introduce new tools, command line arguments, or configuration file options? [No]
  
  If yes, please describe:
  

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
  
  If yes, please describe:
  

Pull Request Testing

• Describe testing already performed for these changes:
  
  Replicated the problem using output from the nightly build on seneca. Confirmed that the fix works as expected.

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  
  Review the code changes and observe the very slightly modified unit test output.

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
  None needed.

• Do these changes include sufficient testing updates? [Yes]
  Slightly tweaked an existing unit test to demonstrate this fix.

• Will this PR result in changes to the test suite? [Yes]
  
  If yes, describe the new output and/or changes to the existing output:
  
  For issue Bugfix: Fix the TC-Stat RIRW runtime error when computing CTS statistics from an empty contingency table #2542, @sethlinden added added an 8th job to the TC-Stat unit test. I modified that job by adding -by amodel. That produces output for both the AHWI and BCLP model names. The BCLP contingency table is empty which triggers this runtime error. Tweaking this newly added tests and confirming that it now runs without error demonstrate the fix. The only modified output file should be tc_stat/ALAL2010_rirw.stat.

• Please complete this pull request review by [Wed May 17, 2023].
  

Pull Request Checklist

See the METplus Workflow for details.

• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select Development issue with the original issue number.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[sethlinden]

Looks good.

[sethlinden]

Code changes look reasonable to me.

[sethlinden]

I reviewed the changes to the config file and to the contable_stats.cc. All looks good to me.

[sethlinden]

I approve of the changes.