Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #2627 v11.1.0 #2632

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Feature #2627 v11.1.0 #2632

merged 1 commit into from
Jul 31, 2023

Conversation

JohnHalleyGotway
Copy link
Collaborator

Expected Differences

Update release notes for 11.1.0 release. I decided to keep it simple and just list the issue numerically within their sections. So the bold ones are not always listed first. But I decided that numeric sorting made these much easier to organize.

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    Built and reviewed the release notes locally.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Review the release notes and confirm the version change from 11.1.0-rc2 to 11.1.0.

Requesting a review from @j-opatz OR @jprestop. Only 1 is required.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]
    None needed.

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Monday 7/31/23].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.1.0 milestone Jul 28, 2023
@JohnHalleyGotway JohnHalleyGotway linked an issue Jul 28, 2023 that may be closed by this pull request
20 tasks
@JohnHalleyGotway JohnHalleyGotway changed the base branch from main_v11.0 to main_v11.1 July 28, 2023 22:24
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the documentation in ReadTheDocs (https://met--2632.org.readthedocs.build/en/2632/Users_Guide/release-notes.html) and check the links carefully for issue numbers. Everything looks good to me! I approve this request.

Copy link
Contributor

@j-opatz j-opatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed layout and list of issues, seems like everything is OK and ready for merging.

@JohnHalleyGotway JohnHalleyGotway merged commit cea2839 into main_v11.1 Jul 31, 2023
1 check passed
@JohnHalleyGotway JohnHalleyGotway deleted the feature_2627_v11.1.0 branch July 31, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Create the official MET-11.1.0 release
3 participants