Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update develop-ref after #2728, #2723, #2736 #2747

Merged
merged 979 commits into from
Nov 17, 2023
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 17, 2023

Updating based on changes from 3 recent PR's:

  1. PR Feature #2550 compute_diagnostics #2728 for issue Enhance TC-Diag to actually compute and write diagnostics #2550 adds new TC-Diag output files.
ERROR: folder /data/output/met_test_truth missing 2 files
    tc_diag/sal092022_gfso_doper_2022092400_cyl_grid_parent.nc 
    tc_diag/sal092022_gfso_doper_2022092400_diag.nc 
ERROR: folder /data/output/met_test_output missing 1 files
    tc_diag/tc_diag_AL092022_GFSO_2022092400_cyl_grid_parent.nc 
  1. PR Feature 2231 unstructured grid #2723 for issue Add support for NetCDF files following the UGRID convention #2231 adds 20 new Point-Stat and Grid-Stat UGRID output files:
ERROR: folder /data/output/met_test_truth missing 20 files
    grid_stat_ugrid/grid_stat_UGRID_MPAS_DIAG_000000L_20120409_120000V.stat 
    grid_stat_ugrid/grid_stat_UGRID_MPAS_DIAG_000000L_20120409_120000V_pairs.nc 
    grid_stat_ugrid/grid_stat_UGRID_MPAS_OUT_TO_GRID_000000L_20120409_120000V.stat 
    grid_stat_ugrid/grid_stat_UGRID_MPAS_OUT_TO_GRID_000000L_20120409_120000V_pairs.nc 
    point_stat_ugrid/point_stat_UGRID_MPAS_DIAG_TEMP_000000L_20120409_120000V.stat 
    point_stat_ugrid/point_stat_UGRID_MPAS_DIAG_TEMP_000000L_20120409_120000V_cnt.txt 
    point_stat_ugrid/point_stat_UGRID_MPAS_DIAG_TEMP_000000L_20120409_120000V_ctc.txt 
    point_stat_ugrid/point_stat_UGRID_MPAS_DIAG_TEMP_000000L_20120409_120000V_cts.txt 
    point_stat_ugrid/point_stat_UGRID_MPAS_DIAG_TEMP_000000L_20120409_120000V_eclv.txt 
    point_stat_ugrid/point_stat_UGRID_MPAS_DIAG_TEMP_000000L_20120409_120000V_fho.txt 
    point_stat_ugrid/point_stat_UGRID_MPAS_DIAG_TEMP_000000L_20120409_120000V_mpr.txt 
    point_stat_ugrid/point_stat_UGRID_MPAS_DIAG_TEMP_000000L_20120409_120000V_vcnt.txt 
    point_stat_ugrid/point_stat_UGRID_MPAS_OUT_TEMP_000000L_20120409_120000V.stat 
    point_stat_ugrid/point_stat_UGRID_MPAS_OUT_TEMP_000000L_20120409_120000V_cnt.txt 
    point_stat_ugrid/point_stat_UGRID_MPAS_OUT_TEMP_000000L_20120409_120000V_ctc.txt 
    point_stat_ugrid/point_stat_UGRID_MPAS_OUT_TEMP_000000L_20120409_120000V_cts.txt 
    point_stat_ugrid/point_stat_UGRID_MPAS_OUT_TEMP_000000L_20120409_120000V_eclv.txt 
    point_stat_ugrid/point_stat_UGRID_MPAS_OUT_TEMP_000000L_20120409_120000V_fho.txt 
    point_stat_ugrid/point_stat_UGRID_MPAS_OUT_TEMP_000000L_20120409_120000V_mpr.txt 
    point_stat_ugrid/point_stat_UGRID_MPAS_OUT_TEMP_000000L_20120409_120000V_vcnt.txt 
  1. PR Feature #2699 consensus_config #2736 for issue Refine TC-Pairs consensus diagnostics configuration options #2699 modifies the contents of an existing TC-Pairs output file.
/data/output/met_test_output/tc_pairs/al092022_20220926_DIAGNOSTICS_CONSENSUS.tcst

Updating develop-ref to get past these diffs.

Created by @JohnHalleyGotway

Howard Soh and others added 30 commits April 14, 2023 11:11
…ocks that might be nice to link to since with a caption, the code block has a copyable link to share.
…s_ncutil

Feature 2474 sonarqube findings ncutil
Fixes typo in Appendix F.
davidalbo and others added 26 commits October 26, 2023 15:06
* mods to use the multivar mode default config (when in multivar mode), and to check for problematic merge config settings

* added more meaningful error and debug messages

* Modified documentation to better describe multivariate mode including new default values

* Bug fix for unit test

* cleanup and fix a bug in which the default output path was not set in multivar mode

* Changed multivar_name value to 'Super' in MODEMultivarConfig_default
Write the output from bootstrap to a log file to determine the autoconf version being run.
* mods to use the multivar mode default config (when in multivar mode), and to check for problematic merge config settings

* added more meaningful error and debug messages

* Modified documentation to better describe multivariate mode including new default values

* Bug fix for unit test

* cleanup and fix a bug in which the default output path was not set in multivar mode

* Changed multivar_name value to 'Super' in MODEMultivarConfig_default

* Update multivar_name value and description in mode.rst

---------

Co-authored-by: John Halley Gotway <[email protected]>
* updating headers for consistency

* fixing headers adding captialization

* capitalizing titles

* adding capitalization to headers

* switching headers back

* updating headers

* updating headers

* capitalizing titles

* capitalizing titles

* Update docs/Contributors_Guide/dev_details/index.rst

Co-authored-by: Julie Prestopnik <[email protected]>

* Update docs/index.rst

Co-authored-by: Julie Prestopnik <[email protected]>

* Update docs/Contributors_Guide/dev_details/index.rst

Co-authored-by: Julie Prestopnik <[email protected]>

* Update docs/Contributors_Guide/dev_details/tmp_file_use.rst

Co-authored-by: Julie Prestopnik <[email protected]>

* Update docs/Contributors_Guide/dev_details/tmp_file_use.rst

Co-authored-by: Julie Prestopnik <[email protected]>

* Update docs/Contributors_Guide/dev_details/tmp_file_use.rst

Co-authored-by: Julie Prestopnik <[email protected]>

* Update docs/Contributors_Guide/dev_details/tmp_file_use.rst

Co-authored-by: Julie Prestopnik <[email protected]>

* Update docs/Contributors_Guide/dev_details/tmp_file_use.rst

Co-authored-by: Julie Prestopnik <[email protected]>

* Update docs/Contributors_Guide/dev_details/tmp_file_use.rst

Co-authored-by: Julie Prestopnik <[email protected]>

* Update docs/Contributors_Guide/dev_details/tmp_file_use.rst

Co-authored-by: Julie Prestopnik <[email protected]>

* Update docs/Contributors_Guide/dev_details/tmp_file_use.rst

Co-authored-by: Julie Prestopnik <[email protected]>

* Update docs/Users_Guide/appendixC.rst

Co-authored-by: Julie Prestopnik <[email protected]>

* Update docs/Users_Guide/masking.rst

Co-authored-by: Julie Prestopnik <[email protected]>

---------

Co-authored-by: Julie Prestopnik <[email protected]>
Co-authored-by: Howard Soh <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>
Co-authored-by: root <root@83062d57c5dd>
Co-authored-by: Tracy Hertneky <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>
@JohnHalleyGotway JohnHalleyGotway changed the title Update develop-ref after #2728, #2723, #2742, #2736 Update develop-ref after #2728, #2723, #2736 Nov 17, 2023
@JohnHalleyGotway JohnHalleyGotway added this to the MET 12.0.0 milestone Nov 17, 2023
@JohnHalleyGotway
Copy link
Collaborator

I note that the differences flagged in this GHA run are all consistent with the expected differences. Will merge this PR and proceed with updating the contents of develop-ref.

@JohnHalleyGotway JohnHalleyGotway merged commit f39afeb into develop-ref Nov 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

10 participants